Closed
Bug 1015333
Opened 11 years ago
Closed 11 years ago
Stop using nsIScriptContext in ImageEncoder's EncodingCompleteEvent
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla33
People
(Reporter: Ms2ger, Assigned: Ms2ger)
Details
Attachments
(2 files)
|
7.44 KB,
patch
|
bholley
:
review-
|
Details | Diff | Splinter Review |
|
7.39 KB,
patch
|
bholley
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Attachment #8427875 -
Flags: review?(bobbyholley)
|
||
Comment 1•11 years ago
|
||
Comment on attachment 8427875 [details] [diff] [review]
Patch v1
Review of attachment 8427875 [details] [diff] [review]:
-----------------------------------------------------------------
Per IRC discussion, this is a rooting hazard. I think we should pass an nsIGlobalObject.
::: content/canvas/src/ImageEncoder.cpp
@@ +38,5 @@
> nsRefPtr<nsDOMMemoryFile> blob =
> new nsDOMMemoryFile(mImgData, mImgSize, mType);
>
> + {
> + AutoSafeJSContext cx;
Let's use an AutoJSAPI here.
Attachment #8427875 -
Flags: review?(bobbyholley) → review-
|
Assignee | |
Comment 2•11 years ago
|
||
Attachment #8447887 -
Flags: review?(bobbyholley)
|
|
||
Updated•11 years ago
|
Attachment #8447887 -
Flags: review?(bobbyholley) → review+
|
|
Assignee | |
Comment 3•11 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla33
|
||
Updated•6 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•