1015370 - Show compatibility warning if an add-on uses __proto__ or setPrototypeOf

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Compatibility Tools, defect)

Description

[Jorge Villalobos [:jorgev] (he/him)]

As explained in bug 948227, using __proto__ or setPrototypeOf to set a prototype is now deprecated. We need to detect any usage of these two and show a warning.

This is a compatibility warning, so the add-on should still be upgraded in this case. It should appear as a warning in regular validations.

Message:

Using __proto__ or setPrototypeOf to set a prototype is now deprecated. You should use Object.create instead. See <LINK> for more information.

Link: https://bugzilla.mozilla.org/show_bug.cgi?id=948227

Affected add-on:

https://addons.mozilla.org/addon/url-link/

Note about milestone: I need these pushed to the validator next week, since the release is only a couple of weeks away. Sorry for the late notice :\

Comment 1

[Mark Striemer [:mstriemer]]

https://github.com/mstriemer/amo-validator/commit/19f9063ac2095bcbccc625067aca2ffa2c6f05bf

Comment 2

[Jorge Villalobos [:jorgev] (he/him)]

(In reply to Jorge Villalobos [:jorgev] from comment #0)
> Affected add-on:
> 
> https://addons.mozilla.org/addon/url-link/

The __proto__ line was commented out, so it's not good for testing. This one should work, I think:

https://addons.mozilla.org/addon/back-to-top/

Comment 3

[Mark Striemer [:mstriemer]]

Attachment: urllink-modified.xpi

Attach failing addon (modified).

Comment 4

[krupa raj[:krupa]]

verified fixed at https://addons.allizom.org/en-US/developers/upload/71bbc25ba7a24f44a7aa41d2565452a8