Closed
Bug 1015377
Opened 10 years ago
Closed 9 years ago
[settings] All sub-headers should be title case not sentence case
Categories
(Firefox OS Graveyard :: Gaia::Settings, defect)
Tracking
(tracking-b2g:backlog, b2g-master fixed)
People
(Reporter: tif, Assigned: oleg.slepov)
Details
(Whiteboard: [good first bug][mentor-lang=zh][lang=js] interaction-design 2.6UXnom)
Attachments
(1 file)
STR 1. Launch Settings app 2. Examine sub-headers 3. Click on various setting options such as Wi-Fi and examine sub-headers Expected: All sub-headers are title case (as per Building Block team) Actual: There is a mixture of title and sentence case
|
Reporter | |
Updated•10 years ago
|
Summary: [settings] All sub-header should be title case not sentence case → [settings] All sub-headers should be title case not sentence case
Whiteboard: interaction-design
|
|
Reporter | |
Updated•9 years ago
|
Whiteboard: interaction-design → interaction-design 2.6UXnom
|
||
Comment 1•9 years ago
|
||
[Tracking Requested - why for this release]:
tracking-b2g:
--- → backlog
Whiteboard: interaction-design 2.6UXnom → [good first bug][mentor-lang=zh][lang=js] interaction-design 2.6UXnom
|
||
Comment 2•9 years ago
|
||
|
||
Updated•9 years ago
|
Attachment #8691251 -
Flags: review?(ehung)
|
|
||
Comment 3•9 years ago
|
||
Evelyn, please review the changes or ask someone else to proceed with review. Thanks in advance.
|
||
Updated•9 years ago
|
Assignee: nobody → Alexey.Yakimov
|
|
||
Comment 4•9 years ago
|
||
Comment on attachment 8691251 [details] [review] [gaia] ruoslepov:bug-1015377-all-sub-headers-should-be-title-case > mozilla-b2g:master Fred, This patch is simple but I didn't check if everywhere is modified. Could you do that? Thanks!
Attachment #8691251 -
Flags: review?(ehung) → review?(gasolin)
|
|
||
Updated•9 years ago
|
Assignee: Alexey.Yakimov → oleg.slepov
|
|
||
Comment 5•9 years ago
|
||
Comment on attachment 8691251 [details] [review] [gaia] ruoslepov:bug-1015377-all-sub-headers-should-be-title-case > mozilla-b2g:master There might be 1 missing subheader 'How does Do Not Track work' https://github.com/mozilla-b2g/gaia/blob/master/apps/settings/locales/settings.en-US.properties#L972 Others looks good
Attachment #8691251 -
Flags: review?(gasolin) → review+
|
|
||
Comment 6•9 years ago
|
||
Thank you, Fred. We also modified the subheader you mentioned and submitted a new commit, so now the patch is ready to be landed I guess.
Keywords: autoland,
checkin-needed
|
||
Comment 7•9 years ago
|
||
https://github.com/mozilla-b2g/gaia/commit/2d81d1697db9bd6cfc5affd886d8d4be56664fdb
Status: NEW → RESOLVED
Closed: 9 years ago
status-b2g-master:
--- → fixed
Keywords: checkin-needed
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•