1015386 - [Clock] Implement new startup loading events

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Clock, defect, P2)

Description

[:Eli Perelman]

+++ This bug was initially created as a clone of Bug #837668 +++

We need to measure when the app is usable by the user. For that we'll need to send an event (the moment is specific to the app) to |window| that the performance test will be able to receive.

The events for implementation are outlined in bug 996038.

Comment 1

[Hubert Figuiere [:hub]]

FYI. There is already a "startup-path-done" in that one.

Comment 2

[:Eli Perelman]

Weird, I could not see that bug when I was looking through all the applications. Closing as dup.

Comment 3

[:Eli Perelman]

Bug 996038 introduces new events outlining the phases of application startup. Each of these 5 events needs to be implemented, so expanding the scope of this bug from just a single event to all 5.

Comment 4

[:Eli Perelman]

As an FYI, this implementation needs to land in 2.0 as it is important for meeting release performance acceptance criteria.

https://wiki.mozilla.org/FirefoxOS/Performance/Release_Acceptance

Comment 5

[Marcus Cavanaugh [:mcav]]

Attachment: Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/20708

This patch includes the events requested. As of this writing I haven't heard about whether PerformanceTestingHelper is still at thing, so there's a "startup-path-done" log in there as well from before. The final three events all fire at once; it is unclear to me that there is any way to meaningfully distinguish between the final three stages for Clock, but suggestions are welcome.

Comment 6

[Hubert Figuiere [:hub]]

Comment on attachment 8442418 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/20708

See comments in the Pull request. Essential stuff is missing...

Comment 7

[Marcus Cavanaugh [:mcav]]

Comment on attachment 8442418 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/20708

I've updated the patch to address your comments (remove the logging, add the whitelist). Regarding the final three events being fired at the same time, my analysis is as follows:

The clock app's main screen displays three things: An analog clock, a list of alarms, and the tab navigation.

The list of alarm is the final thing to load. The app is not 'visually-complete' until the alarm list has fully loaded. When the alarm list has loaded, the alarm events are immediately interactive; the items' event listeners are initialized at the same time the alarms are added to the DOM. So to me, 'moz-content-interactive' should also fire. Finally, the alarm list is the last thing to load -- so the final 'moz-app-loaded' event should be fired. There is no further background processing for Clock.

Based upon the event descriptions Eli gave in 996038, it looks to me like the three final events must fire together for Clock. If you believe they should be split apart more, I'm open to suggestions.

Comment 8

[Hubert Figuiere [:hub]]

Comment on attachment 8442418 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/20708

Looks good.

Comment 9

[Marcus Cavanaugh [:mcav]]

master: https://github.com/mozilla-b2g/gaia/commit/7f883f3a824482a0e80a5213b938cb832b24ab5f

Comment 10

[:Eli Perelman]

Marcus, could you please have your patch uplifted to 2.0? See comment 4.

Comment 11

[:Eli Perelman]

Comment on attachment 8442418 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/20708

Requesting uplift to 2.0 as it is important for meeting our release performance acceptance criteria.

[Feature/regressing bug #]: bug 996038
[User impact if declined]: none
[Describe test coverage new/current, TBPL]: Feature only triggers events for testing, no user-facing features or tests
[Risks and why]: Low, as there are no user-perceived changes
[String/UUID change made/needed]: n/a

Comment 12

[Ryan VanderMeulen [:RyanVM]]

v2.0: https://github.com/mozilla-b2g/gaia/commit/dc8e1899f934e648b8de19bbba072ccadd94f8c6