1015447 - Add a new tab from horizontal tab strip

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Yuan Wang(:Yuan) – Mobile Firefox Design Lead]

Attachment: Add a new tab from tab strip.jpg

With a horizontal tab strip[bug1014987], adding a new tab is just one tap away. 

The “Plus” icon is always visible on the top right side of tab strip. If the user is in a private browsing mode, the "Plus" icon creates a private new tab. 

Next step:
* Implementation
* Animation refinement

Comment 1

[Lucas Rocha (:lucasr)]

Attachment: Top-level container for tab strip with 'new tab' button (r=mcomella)

Comment 2

[Lucas Rocha (:lucasr)]

Comment on attachment 8487177 [details] [diff] [review]
Top-level container for tab strip with 'new tab' button (r=mcomella)

Use a similar approach than BrowserToolbar: top-level container track tab events and forwards them as appropriate.

Comment 3

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Comment on attachment 8487177 [details] [diff] [review]
Top-level container for tab strip with 'new tab' button (r=mcomella)

Review of attachment 8487177 [details] [diff] [review]:
-----------------------------------------------------------------

::: mobile/android/base/tabs/TabStrip.java
@@ +70,5 @@
> +        tabStripView.clearTabs();
> +    }
> +
> +    @Override
> +    public void setPrivateMode(boolean isPrivate) {

This appears to be unused - fix it (and reflag for r?) or file a followup.

Comment 4

[Lucas Rocha (:lucasr)]

Comment on attachment 8487177 [details] [diff] [review]
Top-level container for tab strip with 'new tab' button (r=mcomella)

(In reply to Michael Comella (:mcomella) from comment #3)
> Comment on attachment 8487177 [details] [diff] [review]
> Top-level container for tab strip with 'new tab' button (r=mcomella)
> 
> Review of attachment 8487177 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> ::: mobile/android/base/tabs/TabStrip.java
> @@ +70,5 @@
> > +        tabStripView.clearTabs();
> > +    }
> > +
> > +    @Override
> > +    public void setPrivateMode(boolean isPrivate) {
> 
> This appears to be unused - fix it (and reflag for r?) or file a followup.

It's used when handling the SELECTED event.

Comment 5

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Comment on attachment 8487177 [details] [diff] [review]
Top-level container for tab strip with 'new tab' button (r=mcomella)

Review of attachment 8487177 [details] [diff] [review]:
-----------------------------------------------------------------

My mistake.

Comment 6

[Lucas Rocha (:lucasr)]

https://hg.mozilla.org/integration/fx-team/rev/7b7a4bb58bff

Comment 7

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/7b7a4bb58bff