Closed Bug 1015447 Opened 6 years ago Closed 5 years ago

Add a new tab from horizontal tab strip

Categories

(Firefox for Android :: General, defect)

All
Android
defect
Not set

Tracking

()

RESOLVED FIXED
Firefox 35

People

(Reporter: ywang, Assigned: lucasr)

References

Details

Attachments

(2 files)

With a horizontal tab strip[bug1014987], adding a new tab is just one tap away. 

The “Plus” icon is always visible on the top right side of tab strip. If the user is in a private browsing mode, the "Plus" icon creates a private new tab. 

Next step:
* Implementation
* Animation refinement
Depends on: 1014987
Depends on: 1065369
Comment on attachment 8487177 [details] [diff] [review]
Top-level container for tab strip with 'new tab' button (r=mcomella)

Use a similar approach than BrowserToolbar: top-level container track tab events and forwards them as appropriate.
Attachment #8487177 - Flags: review?(michael.l.comella)
Assignee: nobody → lucasr.at.mozilla
Status: NEW → ASSIGNED
Comment on attachment 8487177 [details] [diff] [review]
Top-level container for tab strip with 'new tab' button (r=mcomella)

Review of attachment 8487177 [details] [diff] [review]:
-----------------------------------------------------------------

::: mobile/android/base/tabs/TabStrip.java
@@ +70,5 @@
> +        tabStripView.clearTabs();
> +    }
> +
> +    @Override
> +    public void setPrivateMode(boolean isPrivate) {

This appears to be unused - fix it (and reflag for r?) or file a followup.
Attachment #8487177 - Flags: review?(michael.l.comella) → review+
Comment on attachment 8487177 [details] [diff] [review]
Top-level container for tab strip with 'new tab' button (r=mcomella)

(In reply to Michael Comella (:mcomella) from comment #3)
> Comment on attachment 8487177 [details] [diff] [review]
> Top-level container for tab strip with 'new tab' button (r=mcomella)
> 
> Review of attachment 8487177 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> ::: mobile/android/base/tabs/TabStrip.java
> @@ +70,5 @@
> > +        tabStripView.clearTabs();
> > +    }
> > +
> > +    @Override
> > +    public void setPrivateMode(boolean isPrivate) {
> 
> This appears to be unused - fix it (and reflag for r?) or file a followup.

It's used when handling the SELECTED event.
Attachment #8487177 - Flags: review+ → review?(michael.l.comella)
Comment on attachment 8487177 [details] [diff] [review]
Top-level container for tab strip with 'new tab' button (r=mcomella)

Review of attachment 8487177 [details] [diff] [review]:
-----------------------------------------------------------------

My mistake.
Attachment #8487177 - Flags: review?(michael.l.comella) → review+
https://hg.mozilla.org/mozilla-central/rev/7b7a4bb58bff
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 35
You need to log in before you can comment on or make changes to this bug.