1015487 - [ADB] all logging broken on b2g

Status: RESOLVED DUPLICATE of bug 1014814

(Core :: Audio/Video, defect)

Description

[Diego Marcos [:dmarcos]]

In todays build:

Gaia      b61129780e085636d09406f2a46e922d0f8b9757
Gecko     https://hg.mozilla.org/mozilla-central/rev/e9b2b72f4e6c
BuildID   20140523040203
Version   32.0a1

Logging don't show up anymore on adb logcat

I can reproduce on Nexus 4 and flame.

Comment 1

[Dave Hylands [:dhylands]]

Some of my code calls __android_log_print and that's not showing up either.

Comment 2

[Dave Hylands [:dhylands]]

This seems to be caused as a side-effect of bug 908503.

That bug causes logd_write.c to be statically linked into lubxul.so

media/libstagefright/system/core/liblog/logd_write.c

Furthermore, media/libstagefright/moz.build contains the line:
DEFINES['FAKE_LOG_DEVICE'] = True

This, in turn causes media/libstagefright/system/core/liblog/fake_log_device.c to be used which directs all of the log messages that used to goto logcat to now goto stderr.

You can see this if you do:

adb shell stop b2g
adb shell /system/bin/b2g.sh

Comment 3

[Dave Hylands [:dhylands]]

Attachment: Patch which restores logging on FirefoxOS devices

Comment 4

[Mike Hommey [:glandium]]

I think you should remove the liblog files from SOURCES and UNIFIED_SOURCES on Android and gonk builds.

Comment 5

[Dave Hylands [:dhylands]]

That sounds like a more reasonable approach. I'll rework my patch to fix it that way.

There is a bunch of other core code which I personally think should NOT be included in libxul.so for gonk (and probably for android):

From SOURCES:
    'system/core/libutils/RefBase.cpp',
    'system/core/libutils/String16.cpp',
    'system/core/libutils/String8.cpp',
    'system/core/libutils/VectorImpl.cpp',

From UNIFIED SOURCES:
    'system/core/libcutils/strdup16to8.c',
    'system/core/libutils/SharedBuffer.cpp',
    'system/core/libutils/Static.cpp',
    'system/core/libutils/Unicode.cpp',

I was going to get muw's opinion on libstagefright itself. What is something in libstagefright changes between ICS/JB/KK, then we'll have bad code in libxul.so

Comment 6

[Dave Hylands [:dhylands]]

Attachment: Rework as per glandium's suggestions

Comment 7

[Mike Hommey [:glandium]]

Comment on attachment 8428201 [details] [diff] [review]
Rework as per glandium's suggestions

Review of attachment 8428201 [details] [diff] [review]:
-----------------------------------------------------------------

::: media/libstagefright/moz.build
@@ +75,5 @@
>      'system/core/libutils/Static.cpp',
>      'system/core/libutils/Unicode.cpp',
>  ]
>  
> +if CONFIG['MOZ_WIDGET_TOOLKIT'] != 'gonk' and CONFIG['MOZ_WIDGET_TOOLKIT'] != 'android':

can be written as if CONFIG['MOZ_WIDGET_TOOLKIT'] not in ('gonk', 'android'):

Comment 9

[Chris Pearce [:cpearce (Not reading bugmail)]]

Comment on attachment 8428201 [details] [diff] [review]
Rework as per glandium's suggestions

Review of attachment 8428201 [details] [diff] [review]:
-----------------------------------------------------------------

Looks like this is being solved in bug 1014814.