1015521 - Make translation provider use available API key

Status: VERIFIED FIXED

(Firefox :: Translations, defect)

Description

[:Felipe Gomes (needinfo for replies!)]

In BingTranslator.jsm, BingTokenManager should use the client id and api key available.

It should:
 - check if hidden prefs exist:
    browser.translation.bing.clientIdOverride and/or
    browser.translation.bing.apiKeyOverride

 - if they exist, use them
 - if they don't exist, use BING_API_CLIENTID and BING_API_KEY provided by nsURLFormatter.js

Both values need to be encodeURLComponent'ed to be used

Comment 1

[Mike de Boer [:mikedeboer]]

Attachment: Patch v1: Bing translation service will now uses available credentials

Comment 2

[:Felipe Gomes (needinfo for replies!)]

Comment on attachment 8431571 [details] [diff] [review]
Patch v1: Bing translation service will now uses available credentials

Review of attachment 8431571 [details] [diff] [review]:
-----------------------------------------------------------------

The encodeURIComponent step comes before the formatURL step. So if the key comes from %BING_API_KEY% instead of the hidden pref, it won't be encoded

Comment 3

[Mike de Boer [:mikedeboer]]

Attachment: Patch v1.1: Bing translation service will now uses available credentials

Good catch! I think this one'll do the trick.

Comment 4

[:Felipe Gomes (needinfo for replies!)]

Comment on attachment 8432459 [details] [diff] [review]
Patch v1.1: Bing translation service will now uses available credentials

Review of attachment 8432459 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks Mike! Code looks good.  Just one suggestion for change: since the main use case is getting the %ABC% keys, and the pref is a fallback, let's rename the method to: getAuthTokenParam (or something like that), and invert the order of the function arguments (token name first, override pref second)

Comment 5

[Mike de Boer [:mikedeboer]]

Pushed to fx-team, with comments addressed: https://hg.mozilla.org/integration/fx-team/rev/7a1a3c3942bd

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/7a1a3c3942bd