Translation FHR should record the state of the translation prefs

VERIFIED FIXED in Firefox 32

Status

()

defect
VERIFIED FIXED
5 years ago
5 years ago

People

(Reporter: Felipe, Assigned: mikedeboer)

Tracking

Trunk
Firefox 32
Points:
---
Dependency tree / graph
Bug Flags:
firefox-backlog +

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: p=3 s=33.1 [qa!])

Attachments

(1 attachment, 1 obsolete attachment)

The state of these two boolean prefs should be recorded together with the other translation fhr/telemetry data, in order to easily distinguish users who are control group, test group, or not using the feature.

browser.translation.detectLanguage
browser.translation.ui.show
Flags: firefox-backlog+
Assignee: nobody → mdeboer
Status: NEW → ASSIGNED
Whiteboard: p=3 s=it-32c-31a-30b.3 [qa+]
No longer blocks: 977774
Depends on: 1017806
Steven, does this patch look like what needs to happen here? If so, I'm reluctant to take credit for this bug, since you did most of the work ;-)

I threw in two freebies:
1. Closing curly brace indentation correction
2. Fixed duplicate test function names
Attachment #8434134 - Flags: feedback?(smacleod)
Steven is out this week, you might want to redirect this to someone else. Maybe Felipe or Florian?
Comment on attachment 8434134 [details] [diff] [review]
Patch v1: changes to translation prefs are now recorded by FHR

Thanks for mentioning that, Tim.
Attachment #8434134 - Flags: feedback?(smacleod) → feedback?(felipc)
dataformat.rst needs to document this change (along with the other translation metrics if they are not already included)
Comment on attachment 8434134 [details] [diff] [review]
Patch v1: changes to translation prefs are now recorded by FHR

Review of attachment 8434134 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me, but i'm not too familiar with the FHR code to know if that's all there's to it :)
Attachment #8434134 - Flags: feedback?(felipc) → feedback+
(In reply to Benjamin Smedberg  [:bsmedberg] from comment #4)
> dataformat.rst needs to document this change (along with the other
> translation metrics if they are not already included)

Already did that in an upcoming patch.
Attachment #8434134 - Attachment is obsolete: true
Attachment #8434244 - Flags: review?(rnewman)
Attachment #8434244 - Flags: review?(rnewman) → review+
No longer depends on: 1017806
Thanks Richard!

Pushed to fx-team as: https://hg.mozilla.org/integration/fx-team/rev/eddaac20ab85
https://hg.mozilla.org/mozilla-central/rev/eddaac20ab85
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 32
Hi Florin, can someone be assigned as the QA contact for verification of this bug.
Flags: needinfo?(florin.mezei)
Flags: needinfo?(florin.mezei)
QA Contact: petruta.rasa
QA Contact: petruta.rasa → bogdan.maris
Whiteboard: p=3 s=it-32c-31a-30b.3 [qa+] → p=3 s=33.1 [qa+]
Verified that FHR records the state of the translation prefs. Tested on Windows 8.1 64bit, Mac OS X 10.9.2 and Ubuntu 14.04 32bit.

Raw Data:
  "org.mozilla.translation.translation": {
     "_v": 1,
     "translationOpportunityCount": 1,
     "detectLanguageEnabled": 1,
     "showTranslationUI": 1,
     "translationOpportunityCountsByLanguage": {
     "fr": 1
     }
  },
Status: RESOLVED → VERIFIED
Whiteboard: p=3 s=33.1 [qa+] → p=3 s=33.1 [qa!]
Could you please also verify that the translation prefs are not recorded if telemetry is disabled?
Flags: needinfo?(bogdan.maris)
(In reply to Benjamin Smedberg  [:bsmedberg] from comment #12)
> Could you please also verify that the translation prefs are not recorded if
> telemetry is disabled?

Sure thing.
Verified that the prefs are not recorded in FHR if telemetry is disabled on Windows 8.1 64bit, Mac OS X 10.9.2 and Ubuntu 14.04 32bit.
Flags: needinfo?(bogdan.maris)
You need to log in before you can comment on or make changes to this bug.