1015525 - Translation FHR should record the state of the translation prefs

Status: VERIFIED FIXED

(Firefox :: Translation, defect)

Description

[:Felipe Gomes (needinfo for replies!)]

The state of these two boolean prefs should be recorded together with the other translation fhr/telemetry data, in order to easily distinguish users who are control group, test group, or not using the feature.

browser.translation.detectLanguage
browser.translation.ui.show

Comment 1

[Mike de Boer [:mikedeboer]]

Attachment: Patch v1: changes to translation prefs are now recorded by FHR

Steven, does this patch look like what needs to happen here? If so, I'm reluctant to take credit for this bug, since you did most of the work ;-)

I threw in two freebies:
1. Closing curly brace indentation correction
2. Fixed duplicate test function names

Comment 2

[Tim Taubert [:ttaubert] (inactive)]

Steven is out this week, you might want to redirect this to someone else. Maybe Felipe or Florian?

Comment 3

[Mike de Boer [:mikedeboer]]

Comment on attachment 8434134 [details] [diff] [review]
Patch v1: changes to translation prefs are now recorded by FHR

Thanks for mentioning that, Tim.

Comment 4

[Benjamin Smedberg]

dataformat.rst needs to document this change (along with the other translation metrics if they are not already included)

Comment 5

[:Felipe Gomes (needinfo for replies!)]

Comment on attachment 8434134 [details] [diff] [review]
Patch v1: changes to translation prefs are now recorded by FHR

Review of attachment 8434134 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me, but i'm not too familiar with the FHR code to know if that's all there's to it :)

Comment 6

[Mike de Boer [:mikedeboer]]

(In reply to Benjamin Smedberg  [:bsmedberg] from comment #4)
> dataformat.rst needs to document this change (along with the other
> translation metrics if they are not already included)

Already did that in an upcoming patch.

Comment 7

[Mike de Boer [:mikedeboer]]

Attachment: Patch v1.1: changes to translation prefs are now recorded by FHR

Comment 8

[Mike de Boer [:mikedeboer]]

Thanks Richard!

Pushed to fx-team as: https://hg.mozilla.org/integration/fx-team/rev/eddaac20ab85

Comment 9

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/eddaac20ab85

Comment 10

[Marco Mucci [:MarcoM]]

Hi Florin, can someone be assigned as the QA contact for verification of this bug.

Comment 11

[Bogdan Maris, Desktop QA]

Verified that FHR records the state of the translation prefs. Tested on Windows 8.1 64bit, Mac OS X 10.9.2 and Ubuntu 14.04 32bit.

Raw Data:
  "org.mozilla.translation.translation": {
     "_v": 1,
     "translationOpportunityCount": 1,
     "detectLanguageEnabled": 1,
     "showTranslationUI": 1,
     "translationOpportunityCountsByLanguage": {
     "fr": 1
     }
  },

Comment 12

[Benjamin Smedberg]

Could you please also verify that the translation prefs are not recorded if telemetry is disabled?

Comment 13

[Bogdan Maris, Desktop QA]

(In reply to Benjamin Smedberg  [:bsmedberg] from comment #12)
> Could you please also verify that the translation prefs are not recorded if
> telemetry is disabled?

Sure thing.
Verified that the prefs are not recorded in FHR if telemetry is disabled on Windows 8.1 64bit, Mac OS X 10.9.2 and Ubuntu 14.04 32bit.