Closed
Bug 1015525
Opened 11 years ago
Closed 11 years ago
Translation FHR should record the state of the translation prefs
Categories
(Firefox :: Translations, defect)
Firefox
Translations
Tracking
()
VERIFIED
FIXED
Firefox 32
People
(Reporter: Felipe, Assigned: mikedeboer)
References
Details
(Whiteboard: p=3 s=33.1 [qa!])
Attachments
(1 file, 1 obsolete file)
7.83 KB,
patch
|
rnewman
:
review+
|
Details | Diff | Splinter Review |
The state of these two boolean prefs should be recorded together with the other translation fhr/telemetry data, in order to easily distinguish users who are control group, test group, or not using the feature.
browser.translation.detectLanguage
browser.translation.ui.show
Updated•11 years ago
|
Flags: firefox-backlog+
Updated•11 years ago
|
Assignee: nobody → mdeboer
Status: NEW → ASSIGNED
Whiteboard: p=3 s=it-32c-31a-30b.3 [qa+]
Assignee | ||
Comment 1•11 years ago
|
||
Steven, does this patch look like what needs to happen here? If so, I'm reluctant to take credit for this bug, since you did most of the work ;-)
I threw in two freebies:
1. Closing curly brace indentation correction
2. Fixed duplicate test function names
Attachment #8434134 -
Flags: feedback?(smacleod)
Comment 2•11 years ago
|
||
Steven is out this week, you might want to redirect this to someone else. Maybe Felipe or Florian?
Assignee | ||
Comment 3•11 years ago
|
||
Comment on attachment 8434134 [details] [diff] [review]
Patch v1: changes to translation prefs are now recorded by FHR
Thanks for mentioning that, Tim.
Attachment #8434134 -
Flags: feedback?(smacleod) → feedback?(felipc)
Comment 4•11 years ago
|
||
dataformat.rst needs to document this change (along with the other translation metrics if they are not already included)
Reporter | ||
Comment 5•11 years ago
|
||
Comment on attachment 8434134 [details] [diff] [review]
Patch v1: changes to translation prefs are now recorded by FHR
Review of attachment 8434134 [details] [diff] [review]:
-----------------------------------------------------------------
Looks good to me, but i'm not too familiar with the FHR code to know if that's all there's to it :)
Attachment #8434134 -
Flags: feedback?(felipc) → feedback+
Assignee | ||
Comment 6•11 years ago
|
||
(In reply to Benjamin Smedberg [:bsmedberg] from comment #4)
> dataformat.rst needs to document this change (along with the other
> translation metrics if they are not already included)
Already did that in an upcoming patch.
Assignee | ||
Comment 7•11 years ago
|
||
Attachment #8434134 -
Attachment is obsolete: true
Attachment #8434244 -
Flags: review?(rnewman)
Updated•11 years ago
|
Attachment #8434244 -
Flags: review?(rnewman) → review+
Assignee | ||
Comment 8•11 years ago
|
||
Thanks Richard!
Pushed to fx-team as: https://hg.mozilla.org/integration/fx-team/rev/eddaac20ab85
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 32
Comment 10•11 years ago
|
||
Hi Florin, can someone be assigned as the QA contact for verification of this bug.
Flags: needinfo?(florin.mezei)
Updated•11 years ago
|
Flags: needinfo?(florin.mezei)
QA Contact: petruta.rasa
Updated•11 years ago
|
QA Contact: petruta.rasa → bogdan.maris
Updated•11 years ago
|
Whiteboard: p=3 s=it-32c-31a-30b.3 [qa+] → p=3 s=33.1 [qa+]
Comment 11•11 years ago
|
||
Verified that FHR records the state of the translation prefs. Tested on Windows 8.1 64bit, Mac OS X 10.9.2 and Ubuntu 14.04 32bit.
Raw Data:
"org.mozilla.translation.translation": {
"_v": 1,
"translationOpportunityCount": 1,
"detectLanguageEnabled": 1,
"showTranslationUI": 1,
"translationOpportunityCountsByLanguage": {
"fr": 1
}
},
Status: RESOLVED → VERIFIED
Whiteboard: p=3 s=33.1 [qa+] → p=3 s=33.1 [qa!]
Comment 12•11 years ago
|
||
Could you please also verify that the translation prefs are not recorded if telemetry is disabled?
Flags: needinfo?(bogdan.maris)
Comment 13•11 years ago
|
||
(In reply to Benjamin Smedberg [:bsmedberg] from comment #12)
> Could you please also verify that the translation prefs are not recorded if
> telemetry is disabled?
Sure thing.
Verified that the prefs are not recorded in FHR if telemetry is disabled on Windows 8.1 64bit, Mac OS X 10.9.2 and Ubuntu 14.04 32bit.
Flags: needinfo?(bogdan.maris)
You need to log in
before you can comment on or make changes to this bug.
Description
•