Closed Bug 1015549 Opened 6 years ago Closed 6 years ago

[mobile] Update filter.py to ignore new keys in region.properties

Categories

(Firefox Build System :: Android Studio and Gradle Integration, defect)

defect
Not set

Tracking

(Not tracked)

VERIFIED FIXED
mozilla32

People

(Reporter: flod, Assigned: flod)

References

Details

Attachments

(1 file)

See also bug 1011620 comment 15
http://hg.mozilla.org/mozilla-central/file/default/mobile/locales/filter.py#l34

This is the current result for compare-locales
https://l10n.mozilla.org/dashboard/compare?run=403204

Should we ignore all keys?
> re.match(r"browser\.suggestedsites\.", entity)
Attached patch bug1015549.patchSplinter Review
I believe it makes sense to ignore brower.suggestedsites.* since we're falling back to en-US if keys are missing.
https://hg.mozilla.org/mozilla-central/diff/2da946c6202c/mobile/locales/en-US/chrome/region.properties

Pike, does it make sense to you?
Attachment #8429221 - Flags: feedback?(l10n)
Attachment #8429221 - Flags: feedback?(l10n) → feedback+
Attachment #8429221 - Flags: review?(rnewman)
Comment on attachment 8429221 [details] [diff] [review]
bug1015549.patch

Review of attachment 8429221 [details] [diff] [review]:
-----------------------------------------------------------------

This looks fine to me, modulo the obvious concern of having two scripts doing the same thing :D

::: mobile/locales/filter.py
@@ +35,5 @@
>      # only region.properties exceptions remain
>      if (re.match(r"browser\.search\.order\.[1-9]", entity) or
>          re.match(r"browser\.contentHandlers\.types\.[0-5]", entity) or
>          re.match(r"gecko\.handlerService\.schemes\.", entity) or
> +        re.match(r"gecko\.handlerService\.defaultHandlersVersion", entity) or

Nit: this regex should probably end in '$'. Fix or not, up to you.
Attachment #8429221 - Flags: review?(rnewman) → review+
Status: NEW → ASSIGNED
Component: Awesomescreen → Build Config & IDE Support
(In reply to Richard Newman [:rnewman] from comment #2)
> Nit: this regex should probably end in '$'. Fix or not, up to you.

Thanks, I prefer to leave this patch as is, but I'll keep it in mind for the next update (I see $ is never used across various products' filter.py).
Assignee: nobody → francesco.lodolo
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/9b7ba1b01c72
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 32
Marking as verified, dashboard is not nagging anymore about missing strings.
Status: RESOLVED → VERIFIED
Product: Firefox for Android → Firefox Build System
Target Milestone: Firefox 32 → mozilla32
You need to log in before you can comment on or make changes to this bug.