Closed Bug 1015634 Opened 7 years ago Closed 7 years ago

The statictitle attribute on the toolkit download manager is still being used in downloads.jsm

Categories

(Toolkit :: Downloads API, defect)

x86
macOS
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla32

People

(Reporter: ehsan.akhgari, Assigned: ehsan.akhgari)

References

Details

Attachments

(1 file)

From bug 822020 comment 3:

> This and bug 817477 removed the statictitle attribute that is still used in
> http://mxr.mozilla.org/mozilla-central/source/toolkit/mozapps/downloads/content/downloads.js

Presumably this causes the title to become empty under those codepaths.
Attached patch Patch (v1)Splinter Review
Assignee: nobody → ehsan
Status: NEW → ASSIGNED
Attachment #8428286 - Flags: review?(mconley)
(In reply to :Ehsan Akhgari (lagging on bugmail, needinfo? me!) from comment #0)
> From bug 822020 comment 3:
> 
> > This and bug 817477 removed the statictitle attribute that is still used in
> > http://mxr.mozilla.org/mozilla-central/source/toolkit/mozapps/downloads/content/downloads.js
> 
> Presumably this causes the title to become empty under those codepaths.

Exactly, I noticed this while working on bug 911636.
Comment on attachment 8428286 [details] [diff] [review]
Patch (v1)

Thanks!
Attachment #8428286 - Flags: review?(mconley) → review+
https://hg.mozilla.org/mozilla-central/rev/65fdc525834c
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla32
You need to log in before you can comment on or make changes to this bug.