Closed
Bug 1015634
Opened 10 years ago
Closed 10 years ago
The statictitle attribute on the toolkit download manager is still being used in downloads.jsm
Categories
(Toolkit :: Downloads API, defect)
Tracking
()
RESOLVED
FIXED
mozilla32
People
(Reporter: ehsan.akhgari, Assigned: ehsan.akhgari)
References
Details
Attachments
(1 file)
|
1.23 KB,
patch
|
mconley
:
review+
|
Details | Diff | Splinter Review |
From bug 822020 comment 3: > This and bug 817477 removed the statictitle attribute that is still used in > http://mxr.mozilla.org/mozilla-central/source/toolkit/mozapps/downloads/content/downloads.js Presumably this causes the title to become empty under those codepaths.
|
Assignee | |
Comment 1•10 years ago
|
||
|
||
Comment 2•10 years ago
|
||
(In reply to :Ehsan Akhgari (lagging on bugmail, needinfo? me!) from comment #0) > From bug 822020 comment 3: > > > This and bug 817477 removed the statictitle attribute that is still used in > > http://mxr.mozilla.org/mozilla-central/source/toolkit/mozapps/downloads/content/downloads.js > > Presumably this causes the title to become empty under those codepaths. Exactly, I noticed this while working on bug 911636.
|
||
Comment 3•10 years ago
|
||
Comment on attachment 8428286 [details] [diff] [review] Patch (v1) Thanks!
Attachment #8428286 -
Flags: review?(mconley) → review+
|
|
Assignee | |
Comment 4•10 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/65fdc525834c
|
||
Comment 5•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/65fdc525834c
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla32
You need to log in
before you can comment on or make changes to this bug.
Description
•