1015635 - Clean up nsObjectLoadingContent::UpdateObjectParameters

Status: RESOLVED INCOMPLETE

(Core Graveyard :: Plug-ins, defect)

Comment 1

[David Zbarsky (:dzbarsky)]

Attachment: Patch

Comment 2

[David Zbarsky (:dzbarsky)]

Attachment: Patch

Forgot to qref

Comment 3

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Comment on attachment 8428289 [details] [diff] [review]
Patch

Review of attachment 8428289 [details] [diff] [review]:
-----------------------------------------------------------------

::: content/base/src/nsObjectLoadingContent.cpp
@@ +1475,5 @@
>    //             bug 853995
>    if (isJava) {
>      // Find all <param> tags that are nested beneath us, but not beneath another
>      // object/applet tag.
> +    Element* mydomElement = thisContent->AsElement();

Why not QI to Element in the first place?

@@ +1488,3 @@
>          if (domelement) {
>            nsAutoString name;
>            domelement->GetAttribute(NS_LITERAL_STRING("name"), name);

Element has one that takes an atom

Comment 4

[David Zbarsky (:dzbarsky)]

(In reply to :Ms2ger from comment #3)
> Comment on attachment 8428289 [details] [diff] [review]
> Patch
> 
> Review of attachment 8428289 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> ::: content/base/src/nsObjectLoadingContent.cpp
> @@ +1475,5 @@
> >    //             bug 853995
> >    if (isJava) {
> >      // Find all <param> tags that are nested beneath us, but not beneath another
> >      // object/applet tag.
> > +    Element* mydomElement = thisContent->AsElement();
> 
> Why not QI to Element in the first place?
> 

Good point.

> @@ +1488,3 @@
> >          if (domelement) {
> >            nsAutoString name;
> >            domelement->GetAttribute(NS_LITERAL_STRING("name"), name);
> 
> Element has one that takes an atom

Fixed.

Comment 5

[David Zbarsky (:dzbarsky)]

Attachment: Patch

Comment 6

[John Schoenick [:johns]]

Comment on attachment 8428303 [details] [diff] [review]
Patch

Review of attachment 8428303 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM

Comment 7

[John Schoenick [:johns]]

@dzbarsky landing ping

Comment 8

[David Zbarsky (:dzbarsky)]

Sorry, I thought I commented on this before.  The patch fails some tests on try and I haven't had time to debug yet.

Comment 9

[Benjamin Smedberg]

Resolving old bugs which are likely not relevant any more, since NPAPI plugins are deprecated.