1015639 - Don't allow underscores in username

Status: RESOLVED FIXED

(Webmaker Graveyard :: Login, defect)

Description

[Jon Buckley [:jbuck]]

Due to bugs in Discourse, Twitter, and an unknown number of URL validators not validating underscores as valid characters in subdomains, I think we should prevent the creation of usernames with underscores in them.

We shouldn't change existing usernames with underscores in them though.

Thoughts?

Comment 1

[Brett Gaylor [:brett]]

agree

Comment 2

[Pomax]

So I heard "I [...] would love to hear some dissenting voices", and am well known for dissent. However, not on this occasion: let's do it. If our username policy is preventing people from using discourse or tweeting because we didn't pay attention to the stricter version of DNS subdomain naming, let's change our policy!

Comment 3

[David Humphrey (:humph)]

I think this is the right move.  +1

Comment 4

[Chris DeCairos (:cade)]

Yes, I think this is a good move.

Comment 5

[Chris DeCairos (:cade)]

Attachment: https://github.com/mozilla/login.webmaker.org/pull/268

Comment 6

[Chris DeCairos (:cade)]

Attachment: https://github.com/mozilla/webmaker-auth-client/pull/25

Comment 7

[[github robot]]

Commit pushed to master at https://github.com/mozilla/login.webmaker.org

https://github.com/mozilla/login.webmaker.org/commit/b56d7374a99f9d8b66d08a005cfc09ad9a960928
Bug 1015639 - disallow underscores in usernames

Comment 8

[[github robot]]

Commit pushed to master at https://github.com/mozilla/webmaker-auth-client

https://github.com/mozilla/webmaker-auth-client/commit/a50775d122a178995aabd936a19a3a509fe171d8
Bug 1015639 - Update error text

Comment 9

[Chris DeCairos (:cade)]

Attachment: https://github.com/mozilla/webmaker.org/pull/757

Updates webmaker-auth-client version used by wm.org, so that is won't allow underscores in usernames.

Comment 10

[Gavin Suntop [:gvn]]

This was in email, but for the "record":

I totally agree. :)

I’d go further to suggest we never use underscores in any URLs or public facing filenames that may end up in a URL (eg: a JPEG, MP3 etc).

My issue with underscores is legibility when viewed in an address bar context.

In a few previous jobs we set a best practice for filenames and URLs, which was: 1. All lowercase. 2. Only hyphens for “spaces", no underscores.

Comment 11

[[github robot]]

Commit pushed to master at https://github.com/mozilla/webmaker.org

https://github.com/mozilla/webmaker.org/commit/3918a892e806fdcaa9c01c22ce12a35b0f79b0d0
Bug 1015639 - Update webmaker-auth-client to version that disallows underscores in usernames

Comment 12

[Chris DeCairos (:cade)]

Attachment: https://github.com/mozilla/popcorn.webmaker.org/pull/547

Comment 13

[Chris DeCairos (:cade)]

Attachment: https://github.com/mozilla/thimble.webmaker.org/pull/428

Comment 14

[[github robot]]

Commit pushed to master at https://github.com/mozilla/popcorn.webmaker.org

https://github.com/mozilla/popcorn.webmaker.org/commit/2f545626be753579efae80c29025b62fe107bc98
Bug 1015639 - update webmaker-auth-client

Comment 15

[Chris DeCairos (:cade)]

Attachment: https://github.com/mozilla/webmaker-events-2/pull/92

Comment 16

[Chris DeCairos (:cade)]

Attachment: https://github.com/mozilla/goggles.webmaker.org/pull/135

Comment 17

[[github robot]]

Commit pushed to master at https://github.com/mozilla/webmaker-events-2

https://github.com/mozilla/webmaker-events-2/commit/b76e453de12318b88f6bb13e8c210135ad3c08f9
Bug 1015639 - Update webmaker-auth-client

Comment 18

[[github robot]]

Commit pushed to master at https://github.com/mozilla/login.webmaker.org

https://github.com/mozilla/login.webmaker.org/commit/f5271f32395276c0c3f02862b975c7146ce91f6e
Revert "Bug 1015639 - disallow underscores in usernames"

This reverts commit b56d7374a99f9d8b66d08a005cfc09ad9a960928.

Comment 19

[Chris DeCairos (:cade)]

Attachment: https://github.com/mozilla/login.webmaker.org/pull/273

Comment 20

[[github robot]]

Commit pushed to master at https://github.com/mozilla/login.webmaker.org

https://github.com/mozilla/login.webmaker.org/commit/55fb1e2b857ac5c524d71fe4f4922b15ca1622de
Bug 1015639 - Update to webmaker-auth-client v0.1.4

Comment 21

[[github robot]]

Commit pushed to master at https://github.com/mozilla/login.webmaker.org

https://github.com/mozilla/login.webmaker.org/commit/154a5cd9e5fe138e93697153492fa040c22fd9cf
Bug 1015639 - disallow usernames - without breaking usernames that already have underscores