1015644 - Clean up ActiveElementManager

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Comment 1

[David Zbarsky (:dzbarsky)]

Attachment: Patch

Comment 2

[Kartikaya Gupta (email:[e-mail])]

Is there a reason for these changes?

Comment 3

[Botond Ballo [:botond]]

Comment on attachment 8428301 [details] [diff] [review]
Patch

Review of attachment 8428301 [details] [diff] [review]:
-----------------------------------------------------------------

::: gfx/layers/apz/util/ActiveElementManager.h
@@ +13,5 @@
>  class CancelableTask;
>  
>  namespace mozilla {
> +namespace dom {
> +class Element;

Don't you need to forward-declare EventTarget as well?

Comment 4

[Botond Ballo [:botond]]

Comment on attachment 8428301 [details] [diff] [review]
Patch

Review of attachment 8428301 [details] [diff] [review]:
-----------------------------------------------------------------

r=me with the missing include and forward-declaration fixed.

(In reply to Kartikaya Gupta (email:[e-mail]) from comment #2)
> Is there a reason for these changes?

Looks like part of a general transitioning from an old set of interfaces (nsIXXX) to a new set (dom::XXX). Fine with me if it doesn't regress anything :)

::: gfx/layers/apz/util/ActiveElementManager.cpp
@@ +11,3 @@
>  #include "base/message_loop.h"
>  #include "base/task.h"
> +#include "mozilla/dom/Element.h"

Likewise, shouldn't you also include "mozilla/dom/EventTarget.h"?

Comment 5

[Kartikaya Gupta (email:[e-mail])]

(In reply to Botond Ballo [:botond] from comment #4)
> Looks like part of a general transitioning from an old set of interfaces
> (nsIXXX) to a new set (dom::XXX). Fine with me if it doesn't regress
> anything :)

In that case this bug should block a meta-bug tracking the overall work so that people can find any relevant context.

Comment 6

[David Zbarsky (:dzbarsky)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/8222bfcd04fb

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/8222bfcd04fb

Comment 8

[Kartikaya Gupta (email:[e-mail])]

Follow-up to fix bustage when AEM_LOG is enabled:

https://hg.mozilla.org/integration/mozilla-inbound/rev/52f0f39c8889

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/52f0f39c8889