Closed
Bug 1015765
Opened 10 years ago
Closed 10 years ago
Need docstrings for methods
Categories
(Add-on SDK Graveyard :: General, defect, P2)
Add-on SDK Graveyard
General
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: jan2011cl+bugzilla, Assigned: jan2011cl+bugzilla)
References
()
Details
(Whiteboard: [has pull request])
Attachments
(2 files, 2 obsolete files)
User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/35.0.1916.114 Safari/537.36 Steps to reproduce: No docstrings Actual results: Docstrings either were not present, or left as comments describing methods Expected results: Docstrings need to be added to python files
Assignee | ||
Updated•10 years ago
|
Assignee: nobody → jan2011cl+bugzilla
Assignee | ||
Comment 1•10 years ago
|
||
Attachment #8431656 -
Flags: review+
Assignee | ||
Comment 2•10 years ago
|
||
Attachment #8431658 -
Flags: review+
Comment 3•10 years ago
|
||
RichieRich: you need to get a patch file and attach it to the bug. https://developer.mozilla.org/en-US/docs/Mercurial_FAQ#How_can_I_generate_a_patch_for_somebody_else_to_check-in_for_me.3F
Updated•10 years ago
|
Attachment #8431656 -
Flags: review+
Updated•10 years ago
|
Attachment #8431658 -
Flags: review+
Updated•10 years ago
|
Whiteboard: [has pull request]
Assignee | ||
Comment 4•10 years ago
|
||
Attachment #8431656 -
Attachment is obsolete: true
Attachment #8431908 -
Flags: review+
Updated•10 years ago
|
Status: UNCONFIRMED → NEW
Ever confirmed: true
Assignee | ||
Updated•10 years ago
|
Attachment #8431908 -
Flags: review+ → review?(evold)
Comment 5•10 years ago
|
||
I'm not sure it's worth landing this, since we are trying to replace cfx with a new tool, and end of life cfx.
Comment 6•10 years ago
|
||
Unless that new tool has patches that are r+ and ready to land, not landing fixes/enhancements for the existing code is, as a general rule, pretty meh. Because who knows when the replacement will actually make it.
Comment 7•10 years ago
|
||
Comment on attachment 8431908 [details] [diff] [review] original.patch We only use spaces, no tabs for indentation.
Attachment #8431908 -
Flags: review?(evold) → review-
Comment 8•10 years ago
|
||
(In reply to Erik Vold [:erikvold] [:ztatic] from comment #7) > Comment on attachment 8431908 [details] [diff] [review] > original.patch > > We only use spaces, no tabs for indentation. I'll land the patch with this change.
Updated•10 years ago
|
Priority: -- → P2
Assignee | ||
Comment 9•10 years ago
|
||
Changed from tabs to spaces
Attachment #8431908 -
Attachment is obsolete: true
Attachment #8437171 -
Flags: review?(wbamberg)
Attachment #8437171 -
Flags: feedback+
Comment 10•10 years ago
|
||
Comment on attachment 8437171 [details] [diff] [review] spaces.patch Looks OK to me, and cfx testall says: 10114 of 10114 tests passed. Total time: 557.046558 seconds Program terminated successfully. Total time for all tests: 721.242576 seconds All tests were successful. Ship it!
Attachment #8437171 -
Flags: review?(wbamberg) → review+
Comment 11•10 years ago
|
||
Commit pushed to master at https://github.com/mozilla/addon-sdk https://github.com/mozilla/addon-sdk/commit/95be1facf55b85ac3938a5cc96e9db59d91b67f8 Merge pull request #1497 from richierichrawr/master Bug 1015765 - Need docstrings for methods
You need to log in
before you can comment on or make changes to this bug.
Description
•