1015780 - Make Moz2D's GetAlignedStride() faster

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Comment 1

[Jonathan Watt [:jwatt]]

Attachment: patch

Comment 2

[Bas Schouten (:bas.schouten)]

Comment on attachment 8428428 [details] [diff] [review]
patch

Review of attachment 8428428 [details] [diff] [review]:
-----------------------------------------------------------------

::: gfx/2d/Tools.h
@@ +140,5 @@
>  
>  template<int alignment>
>  int32_t GetAlignedStride(int32_t aStride)
>  {
> +  const int32_t mask = alignment - 1;

I'm sort of okay with this. But I'm not sure the marginal speed benefit is worth the function not working with NPOT alignments. If we do go this way.. make sure to -clearly- document you can only have power of two alignments. I'm not a big fan.

Comment 3

[Jonathan Watt [:jwatt]]

I added a documenting comment _and_ an assertion. :)

https://hg.mozilla.org/integration/mozilla-inbound/rev/ac5e2c6f4ec0

Comment 4

[Jonathan Watt [:jwatt]]

This time using the correct name:

https://hg.mozilla.org/integration/mozilla-inbound/rev/ff5926ce296d

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/ff5926ce296d