1015781 - Clean up SetInitialChildList/AppendFrames/InsertFrames/RemoveFrame methods

Status: RESOLVED FIXED

(Core :: Layout, defect, P5)

Comment 1

[Mats Palmgren (inactive)]

Attachment: part 1, Make the SetInitialChildList/AppendFrames/InsertFrames/RemoveFrame methods return void (scripted change)

Comment 2

[Mats Palmgren (inactive)]

Attachment: part 2, Remove code handling return values from SetInitialChildList/AppendFrames/InsertFrames/RemoveFrame methods

Comment 3

[Mats Palmgren (inactive)]

Attachment: 1015781-3-void-FrameMethod-whitespace

Comment 4

[Mats Palmgren (inactive)]

Attachment: part 3, Fix whitespace and comments, and move some SetInitialChildList/AppendFrames/InsertFrames/RemoveFrame methods so that they are together in the file

Comment 5

[Mats Palmgren (inactive)]

Attachment: part 4, Make nsColumnSetFrame::SetInitialChildList/AppendFrames/InsertFrames/RemoveFrame DEBUG only and assert that the latter three are not called

Comment 6

[Mats Palmgren (inactive)]

Attachment: part 5, Make nsCanvasFrame::SetInitialChildList/AppendFrames/InsertFrames/RemoveFrame DEBUG only

Comment 7

[Mats Palmgren (inactive)]

Attachment: part 6, Make nsViewportFrame::SetInitialChildList/AppendFrames/InsertFrames/RemoveFrame DEBUG only

Comment 8

[Mats Palmgren (inactive)]

Attachment: part 7, Remove code for handling kAbsoluteList in nsBlockFrame::AppendFrames/InsertFrames/RemoveFrame (it's dead code). Make AppendFrames also handle kNoReflowPrincipalList, for symmetry with InsertF

Comment 9

[Mats Palmgren (inactive)]

Attachment: part 8, Make nsTableCellFrame::AppendFrames/InsertFrames/RemoveFrame DEBUG only

Comment 10

[Mats Palmgren (inactive)]

Attachment: part 9, Make nsFieldSetFrame::SetInitialChildList/AppendFrames/InsertFrames/RemoveFrame DEBUG only

Comment 11

[Mats Palmgren (inactive)]

Attachment: part 10, Make nsHTMLButtonControlFrame::AppendFrames/InsertFrames/RemoveFrame DEBUG only

Comment 12

[Mats Palmgren (inactive)]

Attachment: part 11, Add more assertions in nsTableOuterFrame::SetInitialChildList/AppendFrames/InsertFrames

Comment 13

[Mats Palmgren (inactive)]

https://tbpl.mozilla.org/?tree=Try&rev=4c255ec642c6
https://tbpl.mozilla.org/?tree=Try&rev=09400e5558aa

All parts should result in a working build without any later changes,
except the first two which I will fold together before landing.

Comment 14

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 8429513 [details] [diff] [review]
part 3, Fix whitespace and comments, and move some SetInitialChildList/AppendFrames/InsertFrames/RemoveFrame methods so that they are together in the file

Review of attachment 8429513 [details] [diff] [review]:
-----------------------------------------------------------------

This is fine, although it might have been even better to just stop indenting these parameter names.

Comment 15

[Mats Palmgren (inactive)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/e7cd2558a821
https://hg.mozilla.org/integration/mozilla-inbound/rev/d0427b56178c
https://hg.mozilla.org/integration/mozilla-inbound/rev/f7f0d1fad0f7
https://hg.mozilla.org/integration/mozilla-inbound/rev/262f56b76dac
https://hg.mozilla.org/integration/mozilla-inbound/rev/8d0793e29916
https://hg.mozilla.org/integration/mozilla-inbound/rev/6ae1fc3aa082
https://hg.mozilla.org/integration/mozilla-inbound/rev/2c131e57c737
https://hg.mozilla.org/integration/mozilla-inbound/rev/c9795c1b447c
https://hg.mozilla.org/integration/mozilla-inbound/rev/8f40147b8beb
https://hg.mozilla.org/integration/mozilla-inbound/rev/0957ac98a0b5

Comment 16

[Tim Taubert [:ttaubert] (inactive)]

https://hg.mozilla.org/mozilla-central/rev/e7cd2558a821
https://hg.mozilla.org/mozilla-central/rev/d0427b56178c
https://hg.mozilla.org/mozilla-central/rev/f7f0d1fad0f7
https://hg.mozilla.org/mozilla-central/rev/262f56b76dac
https://hg.mozilla.org/mozilla-central/rev/8d0793e29916
https://hg.mozilla.org/mozilla-central/rev/6ae1fc3aa082
https://hg.mozilla.org/mozilla-central/rev/2c131e57c737
https://hg.mozilla.org/mozilla-central/rev/c9795c1b447c
https://hg.mozilla.org/mozilla-central/rev/8f40147b8beb
https://hg.mozilla.org/mozilla-central/rev/0957ac98a0b5