Closed Bug 1015788 Opened 8 years ago Closed 7 years ago
create flake8 lint script and precommit lint hook
We've got a bunch of code and the code quality is ok, but probably not great. It'd be nice to have a script (and possibly a git pre-commit hook) that runs the code (or changes) through a bunch of linting for style issues so that our style can remain consistent without a lot of effort or back-and-forth in PRs. This bug covers: 1. setting up such things (maybe re-use what Kitsune has?) 2. going through the existing code and fixing style issues
Whiteboard: u=dev c=codequality p= s=input.2014q2
Pushing this off to 2014q3.
Whiteboard: u=dev c=codequality p= s=input.2014q2 → u=dev c=codequality p= s=input.2014q3
analytics app: https://github.com/mozilla/fjord/commit/ed2923fe base app: https://github.com/mozilla/fjord/commit/afdfc6a feedback app: https://github.com/mozilla/fjord/commit/05e0a331 heartbeat app: https://github.com/mozilla/fjord/commit/3d9bc26f
The rest of the cosmetic changes from linting and a script and a pre-commit hook all in PR: https://github.com/mozilla/fjord/pull/339
This is still missing baked (or tariff) and jshint linting.
Assignee: nobody → willkg
Whiteboard: u=dev c=codequality p= s=input.2014q3 → u=dev c=codequality p=2 s=input.2014q3
PR 339 landed in master in: https://github.com/mozilla/fjord/commit/2f212c5efafac0e7a07187ed21b50d9884de8a02
Whiteboard: u=dev c=codequality p=2 s=input.2014q3 → u=dev c=codequality p=2 s=input.2014q4
I just bumped this to 2014q4, but then I thought better of that. Instead, I'm going to reduce the scope of this to just the flake8 stuff and create new bugs for tariff and jshint.
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Whiteboard: u=dev c=codequality p=2 s=input.2014q4 → u=dev c=codequality p=2 s=input.2014q3
Summary: flake8, baked (or tariff) and jshint → create flake8 lint script and precommit lint hook
You need to log in before you can comment on or make changes to this bug.