Closed Bug 1015791 Opened 7 years ago Closed 7 years ago

Give Arrays and TypedArrays a ClassSpec

Categories

(Core :: XPConnect, defect)

x86
macOS
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla32

People

(Reporter: bholley, Assigned: bholley)

References

Details

Attachments

(8 files, 1 obsolete file)

8.54 KB, patch
luke
: review+
Details | Diff | Splinter Review
5.78 KB, patch
luke
: review+
Details | Diff | Splinter Review
1.34 KB, patch
luke
: review+
Details | Diff | Splinter Review
8.11 KB, patch
luke
: review+
Details | Diff | Splinter Review
10.17 KB, patch
luke
: review+
Details | Diff | Splinter Review
5.35 KB, patch
luke
: review+
Details | Diff | Splinter Review
3.14 KB, patch
luke
: review+
Details | Diff | Splinter Review
4.02 KB, patch
luke
: review+
Details | Diff | Splinter Review
We need this for Xrays to Arrays. Hopefully this should be pretty straightforward.
Summary: Give Arrays and TypedArrays a ClassSpec → Give Arrays and TypedArrays a ClassSpec
Note that the Array and TypedArray changes here are very ephemeral, because
we're about to convert these things to ClassSpec (which does this right
automatically) in the upcoming patches.
Attachment #8431238 - Flags: review?(luke)
Attachment #8431239 - Flags: review?(luke)
Attachment #8431238 - Flags: review?(luke) → review+
Attachment #8431239 - Flags: review?(luke) → review+
Attachment #8431240 - Flags: review?(luke) → review+
Comment on attachment 8431241 [details] [diff] [review]
Part 4 - Clean up duplication in release-mode conditionality of *Array.prototype.move. v1

Review of attachment 8431241 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/vm/TypedArrayObject.cpp
@@ +2041,5 @@
>   * TypedArrayObject boilerplate
>   */
>  
> +#ifdef RELEASE_BUILD
> +#define RELEASE_ONLY_FUNCTIONS JS_FN("move", _typedArray##Object::fun_move, 3, JSFUN_GENERIC_NATIVE),

Can you indent 'define' by one space (# define) here and in the #else branch?

@@ +2048,3 @@
>  #endif
>  
> +# define IMPL_TYPED_ARRAY_STATICS(_typedArray)                                     \

Can you unindent # define to be #define?
Attachment #8431241 - Flags: review?(luke) → review+
Attachment #8431242 - Flags: review?(luke) → review+
Attachment #8431243 - Flags: review?(luke) → review+
Attachment #8431244 - Flags: review?(luke) → review+
Looks like this both wouldn't have compiled in RELEASE_MODE, _and_ inverted
the check, making this ship an experimental feature in release builds but not
nightly builds :-(.
Attachment #8431241 - Attachment is obsolete: true
Attachment #8431982 - Flags: review?(luke)
Attachment #8431982 - Flags: review?(luke) → review+
Attachment #8432033 - Flags: review?(luke) → review+
Blocks: 1020609
You need to log in before you can comment on or make changes to this bug.