Closed
Bug 1015791
Opened 7 years ago
Closed 7 years ago
Give Arrays and TypedArrays a ClassSpec
Categories
(Core :: XPConnect, defect)
Tracking
()
RESOLVED
FIXED
mozilla32
People
(Reporter: bholley, Assigned: bholley)
References
Details
Attachments
(8 files, 1 obsolete file)
8.54 KB,
patch
|
luke
:
review+
|
Details | Diff | Splinter Review |
5.78 KB,
patch
|
luke
:
review+
|
Details | Diff | Splinter Review |
1.34 KB,
patch
|
luke
:
review+
|
Details | Diff | Splinter Review |
8.11 KB,
patch
|
luke
:
review+
|
Details | Diff | Splinter Review |
10.17 KB,
patch
|
luke
:
review+
|
Details | Diff | Splinter Review |
5.35 KB,
patch
|
luke
:
review+
|
Details | Diff | Splinter Review |
3.14 KB,
patch
|
luke
:
review+
|
Details | Diff | Splinter Review |
4.02 KB,
patch
|
luke
:
review+
|
Details | Diff | Splinter Review |
We need this for Xrays to Arrays. Hopefully this should be pretty straightforward.
Assignee | ||
Updated•7 years ago
|
Summary: Give Arrays and TypedArrays a ClassSpec → Give Arrays and TypedArrays a ClassSpec
Assignee | ||
Comment 1•7 years ago
|
||
https://tbpl.mozilla.org/?tree=Try&rev=0a2bdc6b9886
Assignee | ||
Comment 2•7 years ago
|
||
https://tbpl.mozilla.org/?tree=Try&rev=b8b4cbff3269
Assignee | ||
Comment 3•7 years ago
|
||
https://tbpl.mozilla.org/?tree=Try&rev=e35bfa480750
Assignee | ||
Comment 4•7 years ago
|
||
Note that the Array and TypedArray changes here are very ephemeral, because we're about to convert these things to ClassSpec (which does this right automatically) in the upcoming patches.
Attachment #8431238 -
Flags: review?(luke)
Assignee | ||
Comment 5•7 years ago
|
||
Attachment #8431239 -
Flags: review?(luke)
Assignee | ||
Comment 6•7 years ago
|
||
Attachment #8431240 -
Flags: review?(luke)
Assignee | ||
Comment 7•7 years ago
|
||
Attachment #8431241 -
Flags: review?(luke)
Assignee | ||
Comment 8•7 years ago
|
||
Attachment #8431242 -
Flags: review?(luke)
Assignee | ||
Comment 9•7 years ago
|
||
Attachment #8431243 -
Flags: review?(luke)
Assignee | ||
Comment 10•7 years ago
|
||
Attachment #8431244 -
Flags: review?(luke)
![]() |
||
Updated•7 years ago
|
Attachment #8431238 -
Flags: review?(luke) → review+
![]() |
||
Updated•7 years ago
|
Attachment #8431239 -
Flags: review?(luke) → review+
![]() |
||
Updated•7 years ago
|
Attachment #8431240 -
Flags: review?(luke) → review+
![]() |
||
Comment 11•7 years ago
|
||
Comment on attachment 8431241 [details] [diff] [review] Part 4 - Clean up duplication in release-mode conditionality of *Array.prototype.move. v1 Review of attachment 8431241 [details] [diff] [review]: ----------------------------------------------------------------- ::: js/src/vm/TypedArrayObject.cpp @@ +2041,5 @@ > * TypedArrayObject boilerplate > */ > > +#ifdef RELEASE_BUILD > +#define RELEASE_ONLY_FUNCTIONS JS_FN("move", _typedArray##Object::fun_move, 3, JSFUN_GENERIC_NATIVE), Can you indent 'define' by one space (# define) here and in the #else branch? @@ +2048,3 @@ > #endif > > +# define IMPL_TYPED_ARRAY_STATICS(_typedArray) \ Can you unindent # define to be #define?
Attachment #8431241 -
Flags: review?(luke) → review+
![]() |
||
Updated•7 years ago
|
Attachment #8431242 -
Flags: review?(luke) → review+
![]() |
||
Updated•7 years ago
|
Attachment #8431243 -
Flags: review?(luke) → review+
![]() |
||
Updated•7 years ago
|
Attachment #8431244 -
Flags: review?(luke) → review+
Assignee | ||
Comment 12•7 years ago
|
||
remote: https://hg.mozilla.org/integration/mozilla-inbound/rev/46dd7365c75a remote: https://hg.mozilla.org/integration/mozilla-inbound/rev/2870c471fe25 remote: https://hg.mozilla.org/integration/mozilla-inbound/rev/633661dee416 remote: https://hg.mozilla.org/integration/mozilla-inbound/rev/d8f29a74c74a remote: https://hg.mozilla.org/integration/mozilla-inbound/rev/b1abfb5152fd remote: https://hg.mozilla.org/integration/mozilla-inbound/rev/76a617bf6fe3 remote: https://hg.mozilla.org/integration/mozilla-inbound/rev/a51011a46872
Backed out in https://hg.mozilla.org/integration/mozilla-inbound/rev/20361da59e6d for build bustage: https://tbpl.mozilla.org/php/getParsedLog.php?id=40763805&tree=Mozilla-Inbound These failed on at least B2G emulator and device image builds.
Flags: needinfo?(bobbyholley)
Assignee | ||
Comment 14•7 years ago
|
||
Looks like this both wouldn't have compiled in RELEASE_MODE, _and_ inverted the check, making this ship an experimental feature in release builds but not nightly builds :-(.
Attachment #8431241 -
Attachment is obsolete: true
Attachment #8431982 -
Flags: review?(luke)
Assignee | ||
Comment 15•7 years ago
|
||
Attachment #8432033 -
Flags: review?(luke)
Assignee | ||
Comment 16•7 years ago
|
||
https://tbpl.mozilla.org/?tree=Try&rev=ed76342800df
Flags: needinfo?(bobbyholley)
![]() |
||
Updated•7 years ago
|
Attachment #8431982 -
Flags: review?(luke) → review+
![]() |
||
Updated•7 years ago
|
Attachment #8432033 -
Flags: review?(luke) → review+
Assignee | ||
Comment 17•7 years ago
|
||
remote: https://hg.mozilla.org/integration/mozilla-inbound/rev/54fdf394e808 remote: https://hg.mozilla.org/integration/mozilla-inbound/rev/4b633a2d7803 remote: https://hg.mozilla.org/integration/mozilla-inbound/rev/70aedc180581 remote: https://hg.mozilla.org/integration/mozilla-inbound/rev/94e79e259c6c remote: https://hg.mozilla.org/integration/mozilla-inbound/rev/183913f9fe6d remote: https://hg.mozilla.org/integration/mozilla-inbound/rev/01aa986b9693 remote: https://hg.mozilla.org/integration/mozilla-inbound/rev/a74551f232ce remote: https://hg.mozilla.org/integration/mozilla-inbound/rev/61567a7e3d66
Comment 18•7 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/54fdf394e808 https://hg.mozilla.org/mozilla-central/rev/4b633a2d7803 https://hg.mozilla.org/mozilla-central/rev/70aedc180581 https://hg.mozilla.org/mozilla-central/rev/94e79e259c6c https://hg.mozilla.org/mozilla-central/rev/183913f9fe6d https://hg.mozilla.org/mozilla-central/rev/01aa986b9693 https://hg.mozilla.org/mozilla-central/rev/a74551f232ce https://hg.mozilla.org/mozilla-central/rev/61567a7e3d66
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla32
You need to log in
before you can comment on or make changes to this bug.
Description
•