1015791 - Give Arrays and TypedArrays a ClassSpec

Status: RESOLVED FIXED

(Core :: XPConnect, defect)

Description

[Bobby Holley (:bholley)]

We need this for Xrays to Arrays. Hopefully this should be pretty straightforward.

Comment 1

[Bobby Holley (:bholley)]

https://tbpl.mozilla.org/?tree=Try&rev=0a2bdc6b9886

Comment 2

[Bobby Holley (:bholley)]

https://tbpl.mozilla.org/?tree=Try&rev=b8b4cbff3269

Comment 3

[Bobby Holley (:bholley)]

https://tbpl.mozilla.org/?tree=Try&rev=e35bfa480750

Comment 4

[Bobby Holley (:bholley)]

Attachment: Part 1 - Retrieve the constructor for the slot, rather than looking up |proto.constructor|, for JSFUN_GENERIC_NATIVE functions. v1

Note that the Array and TypedArray changes here are very ephemeral, because
we're about to convert these things to ClassSpec (which does this right
automatically) in the upcoming patches.

Comment 5

[Bobby Holley (:bholley)]

Attachment: Part 2 - Give Array a ClassSpec. v1

Comment 6

[Bobby Holley (:bholley)]

Attachment: Part 3 - Stop assuming that all TypedArray classes are initialized simultaneously. v1

Comment 7

[Bobby Holley (:bholley)]

Attachment: Part 4 - Clean up duplication in release-mode conditionality of *Array.prototype.move. v1

Comment 8

[Bobby Holley (:bholley)]

Attachment: Part 5 - Hoist TypedArray properties into a JSPropertySpec. v1

Comment 9

[Bobby Holley (:bholley)]

Attachment: Part 6 - Give TypedArray classes a ClassSpec. v1

Comment 10

[Bobby Holley (:bholley)]

Attachment: Part 7 - Break up the remainder of js_InitTypedArrayClasses. v1

Comment 11

[Luke Wagner [:luke]]

Comment on attachment 8431241 [details] [diff] [review]
Part 4 - Clean up duplication in release-mode conditionality of *Array.prototype.move. v1

Review of attachment 8431241 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/vm/TypedArrayObject.cpp
@@ +2041,5 @@
>   * TypedArrayObject boilerplate
>   */
>  
> +#ifdef RELEASE_BUILD
> +#define RELEASE_ONLY_FUNCTIONS JS_FN("move", _typedArray##Object::fun_move, 3, JSFUN_GENERIC_NATIVE),

Can you indent 'define' by one space (# define) here and in the #else branch?

@@ +2048,3 @@
>  #endif
>  
> +# define IMPL_TYPED_ARRAY_STATICS(_typedArray)                                     \

Can you unindent # define to be #define?

Comment 12

[Bobby Holley (:bholley)]

remote:   https://hg.mozilla.org/integration/mozilla-inbound/rev/46dd7365c75a
remote:   https://hg.mozilla.org/integration/mozilla-inbound/rev/2870c471fe25
remote:   https://hg.mozilla.org/integration/mozilla-inbound/rev/633661dee416
remote:   https://hg.mozilla.org/integration/mozilla-inbound/rev/d8f29a74c74a
remote:   https://hg.mozilla.org/integration/mozilla-inbound/rev/b1abfb5152fd
remote:   https://hg.mozilla.org/integration/mozilla-inbound/rev/76a617bf6fe3
remote:   https://hg.mozilla.org/integration/mozilla-inbound/rev/a51011a46872

Comment 13

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Backed out in https://hg.mozilla.org/integration/mozilla-inbound/rev/20361da59e6d for build bustage: https://tbpl.mozilla.org/php/getParsedLog.php?id=40763805&tree=Mozilla-Inbound

These failed on at least B2G emulator and device image builds.

Comment 14

[Bobby Holley (:bholley)]

Attachment: Part 4 - Clean up duplication in release-mode conditionality of *Array.prototype.move. v3

Looks like this both wouldn't have compiled in RELEASE_MODE, _and_ inverted
the check, making this ship an experimental feature in release builds but not
nightly builds :-(.

Comment 15

[Bobby Holley (:bholley)]

Attachment: Part 8 - Work around ICS compiler bugs. v1

Comment 16

[Bobby Holley (:bholley)]

https://tbpl.mozilla.org/?tree=Try&rev=ed76342800df

Comment 17

[Bobby Holley (:bholley)]

remote:   https://hg.mozilla.org/integration/mozilla-inbound/rev/54fdf394e808
remote:   https://hg.mozilla.org/integration/mozilla-inbound/rev/4b633a2d7803
remote:   https://hg.mozilla.org/integration/mozilla-inbound/rev/70aedc180581
remote:   https://hg.mozilla.org/integration/mozilla-inbound/rev/94e79e259c6c
remote:   https://hg.mozilla.org/integration/mozilla-inbound/rev/183913f9fe6d
remote:   https://hg.mozilla.org/integration/mozilla-inbound/rev/01aa986b9693
remote:   https://hg.mozilla.org/integration/mozilla-inbound/rev/a74551f232ce
remote:   https://hg.mozilla.org/integration/mozilla-inbound/rev/61567a7e3d66

Comment 18

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/54fdf394e808
https://hg.mozilla.org/mozilla-central/rev/4b633a2d7803
https://hg.mozilla.org/mozilla-central/rev/70aedc180581
https://hg.mozilla.org/mozilla-central/rev/94e79e259c6c
https://hg.mozilla.org/mozilla-central/rev/183913f9fe6d
https://hg.mozilla.org/mozilla-central/rev/01aa986b9693
https://hg.mozilla.org/mozilla-central/rev/a74551f232ce
https://hg.mozilla.org/mozilla-central/rev/61567a7e3d66