1015820 - [Contacts] Screen not repaint properly after deleting contact

Status: VERIFIED FIXED

(Core :: Graphics: Layers, defect)

Description

[Eric Chang [:ericcc] [:echang]]

Attachment: ContactsShadow.png

### STR
1. Make sure there is only ONE entry in Contacts.
2. Tap "Settings".
3. Tap "Delete Contacts".
4. Delete any of the entry.
5. <ISSUE> Shadow in Contacts. See ContactsShadow.png
6. Shadow gone, if lockscreen on and off.
7. Tap "Settings", "Done".
8. <ISSUE> "No Contacts, Start adding them now..." appears on top of the shadow layer, see 

### Reproduce Rate
100%

### Version
Gaia      f3b5d74dd3428c89cab06db734c62f3c9dbb8c4d
Gecko     https://hg.mozilla.org/mozilla-central/rev/e86a0d92d174
BuildID   20140525160203
Version   32.0a1
ro.build.version.incremental=324
ro.build.date=Thu Dec 19 14:04:55 CST 2013

Comment 1

[Eric Chang [:ericcc] [:echang]]

Attachment: ContactsShadowSettings.png

For Step 8 above.

Comment 2

[Eric Chang [:ericcc] [:echang]]

Hi, Jose, Could you help to take a look at this, thank you.

Comment 3

[Marina Rodríguez [:mai]]

Attachment: patch v1.0

Hi Jose, 
do you mind reviewing the patch?
Regards

Comment 4

[Marina Rodríguez [:mai]]

Comment on attachment 8429376 [details]
patch v1.0

>https://github.com/mozilla-b2g/gaia/pull/19682

Comment 5

[Marina Rodríguez [:mai]]

Comment on attachment 8429376 [details]
patch v1.0

>https://github.com/mozilla-b2g/gaia/pull/19682

Comment 6

[Jose Manuel Cantera]

Comment on attachment 8429376 [details]
patch v1.0

the proposed introduce regressions. I believe we should ask for help to the Gpx people as this seems to be a Gpx Gecko Regression.

Comment 7

[Jose Manuel Cantera]

Ben,

Could you help us in identifying the right people to forward this? It seems to be a recent Gecko regression.

Thanks

Comment 8

[Ben Kelly [:bkelly, not reviewing]]

It appears there is a strange layerization issue going on here.  Is there anyone from gfx who can look at this or at least help rule it out?

Jose, Marina, it might help if you enable layer borders in the developer menu and get a new screenshot.  I'd be interested to know if the black "shadow" box has its own layer or not.  (I assume it must.)

Comment 9

[Marina Rodríguez [:mai]]

Attachment: screenshot with layers

The new attachment is a screenshot with the layer borders enabled,
Regards

Comment 10

[Milan Sreckovic [:milan] (needinfo for best results)]

I'm assuming this is a regression?  Let's get the regression window and take it from there.  Also, on all devices?

Comment 11

[Milan Sreckovic [:milan] (needinfo for best results)]

When looking for the regression range - this worked for me with 05/22 build, but not 05/28.

Comment 12

[Maria Angeles Oteo (:oteo)]

Adding to the STR in the description that this bug appears always that we select to delete ALL the contacts available agenda, independently if there are one, two or more... or if we select them manually or with "select all" button

Tested in latest master build in a buri device.
B-180
Gecko-4a08636
Gaia-eca8a38

Comment 13

[Milan Sreckovic [:milan] (needinfo for best results)]

So far I don't see the problem in this nightly:
2014-05-23-04-02-03
and I see the problem show up first in this nightly:
2014-05-23-16-02-04
at least on Nexus 4.

Comment 14

[Milan Sreckovic [:milan] (needinfo for best results)]

Good (2014-05-23-04-02-03):
Gecko: e4bc303acede847a913b70afa47fd6823b97297a
Gaia: b61129780e085636d09406f2a46e922d0f8b9757

Bad (2014-05-23-16-02-04):
Gecko: 203ded0aa097a774b9eff43c60de9b5065081dea
Gaia: e83bd91c8f7c66f95d55cb741299e12bc8f7b429

Mixing Gecko from "Good" and Gaia from "Bad", I don't see the problem, so I would imagine this is in Gecko.

Comment 15

[Jason Smith [:jsmith]]

Let's get a push log against tinderbox & indicate if this reproduces on 1.4 or not.

Comment 16

[Duane Dixon [:ddixon]]

Issue DOES NOT occur in latest 1.4 Flame build.
Issue DOES NOT occur in latest 1.4 Buri build. 
Issue DOES NOT occur in latest 2.0 Flame Build. 

Issue DOES occur in 2.0 Buri builds.

B2G Inbound Regression Window on a Buri device. 

Last Working: 

Device: Buri
Build ID: 20140523154921
Gaia: 067025545d363dcb689e59413e8f112b308bb751
Gecko: 718b0c6fa873
Version: 32.0a1 (2.0) MOZ
Firmware Version: v1.2device.cfg

First Broken: 

Device: Buri
BuildID: 20140523174420
Gaia: 9e962fa357001eb5362e30050b83808813fe98a3
Gecko: 963cddfee20f
Version: 32.0a1 (2.0) MOZ
Firmware Version: v1.2device.cfg

Gecko Push log: http://hg.mozilla.org/integration/b2g-inbound/pushloghtml?fromchange=718b0c6fa873&tochange=963cddfee20f

I am also able to provide a Central 2.0 Regression Window and Push log if needed.

Comment 17

[Jason Smith [:jsmith]]

Push log looks incorrect & there's no gaia/gecko swap above.

Comment 18

[Duane Dixon [:ddixon]]

(In reply to Jason Smith [:jsmith] from comment #17)
> Push log looks incorrect & there's no gaia/gecko swap above.

Gaia & Gecko swap for comment 16. 

Last Working Gaia and First Broken Gecko
Issue DOES occur here. 
Gaia: 067025545d363dcb689e59413e8f112b308bb751
Gecko: 963cddfee20f

Last Working Gecko and First Broken Gaia
Issue DOES NOT occur here. 
Gaia: 9e962fa357001eb5362e30050b83808813fe98a3
Gecko: 718b0c6fa873

Comment 19

[Duane Dixon [:ddixon]]

Mozilla Inbound Regression Window 


Last Working build

Environmental Variables:
Device: Buri
Build ID: 20140522203028
Gaia: b61129780e085636d09406f2a46e922d0f8b9757
Gecko: 5c8fac4197de
Version: 32.0a1 (2.0) MOZ
Firmware Version: v1.2device.cfg

First Broken build

Environmental Variables:
Device: Buri
Build ID: 20140522210223
Gaia: b61129780e085636d09406f2a46e922d0f8b9757
Gecko: 8286affa4d6e
Version: 32.0a1 (2.0) MOZ
Firmware Version: v1.2device.cfg


Last Working Gaia and First Broken Gecko
Issue DOES occur here. 
Gaia: b61129780e085636d09406f2a46e922d0f8b9757
Gecko: 8286affa4d6e

Last Working Gecko and First Broken Gaia
Issue DOES not occur here. 
Gaia: b61129780e085636d09406f2a46e922d0f8b9757
Gecko: 5c8fac4197de

Gecko Pushlog: http://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=5c8fac4197de&tochange=8286affa4d6e

Comment 20

[Jason Smith [:jsmith]]

Broken by bug 1012213.

Bas - Can you investigate?

Comment 21

[Bas Schouten (:bas.schouten)]

Attachment: Potential fix

I believe this will fix the issue but don't have a build handy to test.

Comment 22

[Bas Schouten (:bas.schouten)]

Comment on attachment 8431932 [details] [diff] [review]
Potential fix

Review of attachment 8431932 [details] [diff] [review]:
-----------------------------------------------------------------

I'm pretty sure this will be it. Milan will test.

Comment 23

[Milan Sreckovic [:milan] (needinfo for best results)]

Comment on attachment 8431932 [details] [diff] [review]
Potential fix

Review of attachment 8431932 [details] [diff] [review]:
-----------------------------------------------------------------

Fixes the problem for me.

Comment 24

[Bas Schouten (:bas.schouten)]

http://hg.mozilla.org/integration/mozilla-inbound/rev/c1acd3bf21ed

Comment 25

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/c1acd3bf21ed

Comment 26

[Eric Chang [:ericcc] [:echang]]

Works okay with these 2 builds.
Flame Aurora v2.0
Gaia      1dd043857399c713e3b509c0ed31bdf20326f08b
Gecko     https://hg.mozilla.org/releases/mozilla-aurora/rev/3f9d7a3a0b7b
BuildID   20140707160206
Version   32.0a2
ro.build.version.incremental=109
ro.build.date=Mon Jun 16 16:51:29 CST 2014
B1TC00011220

Flame Master v2.1
Gaia      e935f4ff190b76c70d9b2af8856c542a6e4a7546
Gecko     https://hg.mozilla.org/releases/mozilla-aurora/rev/3f9d7a3a0b7b
BuildID   20140707160206
Version   32.0a2
ro.build.version.incremental=109
ro.build.date=Mon Jun 16 16:51:29 CST 2014
B1TC00011220