1015828 - make Fake_SourceMediaStream::mDesiredTime increments consistent with timer period and buffer size

Status: RESOLVED FIXED

(Core :: WebRTC: Signaling, defect)

Description

[Karl Tomlinson (:karlt)]

mDesiredTime is incremented by 10ms, which seems inconsistent with the timer period of 100ms and the buffer size of 1600 @ 16000Hz.

Comment 1

[Karl Tomlinson (:karlt)]

It seems that the value does influence the result of signaling_unittests if very wrong:

Using 1ms:
[----------] Global test environment tear-down
[==========] 83 tests from 2 test cases ran. (266348 ms total)
[  PASSED  ] 69 tests.
[  FAILED  ] 14 tests, listed below:
[  FAILED  ] SignalingTest.FullCall
[  FAILED  ] SignalingTest.FullCallAudioOnly
[  FAILED  ] SignalingTest.FullCallAnswererRejectsVideo
[  FAILED  ] SignalingTest.FullCallTrickle
[  FAILED  ] SignalingTest.FullCallTrickleChrome
[  FAILED  ] SignalingTest.AudioOnlyCalleeNoRtcpMux
[  FAILED  ] SignalingTest.FullCallAudioNoMuxVideoMux
[  FAILED  ] SignalingTest.AudioCallForceDtlsRoles
[  FAILED  ] SignalingTest.AudioCallReverseDtlsRoles
[  FAILED  ] SignalingTest.AudioCallGarbageSetup
[  FAILED  ] SignalingTest.AudioCallOfferNoSetupOrConnection
[  FAILED  ] SignalingTest.AudioCallAnswerNoSetupOrConnection
[  FAILED  ] SignalingTest.FullCallRealTrickle
[  FAILED  ] SignalingTest.FullCallRealTrickleTestServer

Using 10000ms:
[----------] Global test environment tear-down
[==========] 84 tests from 2 test cases ran. (322323 ms total)
[  PASSED  ] 69 tests.
[  FAILED  ] 15 tests, listed below:
[  FAILED  ] SignalingTest.FullCall
[  FAILED  ] SignalingTest.FullCallAudioOnly
[  FAILED  ] SignalingTest.FullCallAnswererRejectsVideo
[  FAILED  ] SignalingTest.FullCallTrickle
[  FAILED  ] SignalingTest.FullCallTrickleChrome
[  FAILED  ] SignalingTest.AudioOnlyCalleeNoRtcpMux
[  FAILED  ] SignalingTest.FullCallAudioNoMuxVideoMux
[  FAILED  ] SignalingTest.AudioCallForceDtlsRoles
[  FAILED  ] SignalingTest.AudioCallReverseDtlsRoles
[  FAILED  ] SignalingTest.AudioCallMismatchDtlsRoles
[  FAILED  ] SignalingTest.AudioCallGarbageSetup
[  FAILED  ] SignalingTest.AudioCallOfferNoSetupOrConnection
[  FAILED  ] SignalingTest.AudioCallAnswerNoSetupOrConnection
[  FAILED  ] SignalingTest.FullCallRealTrickle
[  FAILED  ] SignalingTest.FullCallRealTrickleTestServer

1000ms still passes.

Comment 2

[Karl Tomlinson (:karlt)]

Attachment: increment Fake_SourceMediaStream::mDesiredTime each period instead of each listener notification

I think this fixes code introduced in
http://hg.mozilla.org/mozilla-central/rev/1b88be2c5e1f#l2.13

Comment 3

[Karl Tomlinson (:karlt)]

Attachment: match Fake_MediaStreamListener::NotifyPull time advances to timer period and Fake_AudioStreamSource::Periodic buffer size

Comment 4

[Randell Jesup [:jesup] (needinfo me)]

Comment on attachment 8428504 [details] [diff] [review]
match Fake_MediaStreamListener::NotifyPull time advances to timer period and Fake_AudioStreamSource::Periodic buffer size

Review of attachment 8428504 [details] [diff] [review]:
-----------------------------------------------------------------

Please fold these patches for checkin.  Thanks!

Comment 5

[aditi]

GUD JOB

Comment 6

[Karl Tomlinson (:karlt)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/9e1590531e5c

Comment 7

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/9e1590531e5c