Closed Bug 1015828 Opened 6 years ago Closed 6 years ago

make Fake_SourceMediaStream::mDesiredTime increments consistent with timer period and buffer size

Categories

(Core :: WebRTC: Signaling, defect)

x86_64
Linux
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla32

People

(Reporter: karlt, Assigned: karlt)

References

Details

Attachments

(2 files)

mDesiredTime is incremented by 10ms, which seems inconsistent with the timer period of 100ms and the buffer size of 1600 @ 16000Hz.
It seems that the value does influence the result of signaling_unittests if very wrong:

Using 1ms:
[----------] Global test environment tear-down
[==========] 83 tests from 2 test cases ran. (266348 ms total)
[  PASSED  ] 69 tests.
[  FAILED  ] 14 tests, listed below:
[  FAILED  ] SignalingTest.FullCall
[  FAILED  ] SignalingTest.FullCallAudioOnly
[  FAILED  ] SignalingTest.FullCallAnswererRejectsVideo
[  FAILED  ] SignalingTest.FullCallTrickle
[  FAILED  ] SignalingTest.FullCallTrickleChrome
[  FAILED  ] SignalingTest.AudioOnlyCalleeNoRtcpMux
[  FAILED  ] SignalingTest.FullCallAudioNoMuxVideoMux
[  FAILED  ] SignalingTest.AudioCallForceDtlsRoles
[  FAILED  ] SignalingTest.AudioCallReverseDtlsRoles
[  FAILED  ] SignalingTest.AudioCallGarbageSetup
[  FAILED  ] SignalingTest.AudioCallOfferNoSetupOrConnection
[  FAILED  ] SignalingTest.AudioCallAnswerNoSetupOrConnection
[  FAILED  ] SignalingTest.FullCallRealTrickle
[  FAILED  ] SignalingTest.FullCallRealTrickleTestServer

Using 10000ms:
[----------] Global test environment tear-down
[==========] 84 tests from 2 test cases ran. (322323 ms total)
[  PASSED  ] 69 tests.
[  FAILED  ] 15 tests, listed below:
[  FAILED  ] SignalingTest.FullCall
[  FAILED  ] SignalingTest.FullCallAudioOnly
[  FAILED  ] SignalingTest.FullCallAnswererRejectsVideo
[  FAILED  ] SignalingTest.FullCallTrickle
[  FAILED  ] SignalingTest.FullCallTrickleChrome
[  FAILED  ] SignalingTest.AudioOnlyCalleeNoRtcpMux
[  FAILED  ] SignalingTest.FullCallAudioNoMuxVideoMux
[  FAILED  ] SignalingTest.AudioCallForceDtlsRoles
[  FAILED  ] SignalingTest.AudioCallReverseDtlsRoles
[  FAILED  ] SignalingTest.AudioCallMismatchDtlsRoles
[  FAILED  ] SignalingTest.AudioCallGarbageSetup
[  FAILED  ] SignalingTest.AudioCallOfferNoSetupOrConnection
[  FAILED  ] SignalingTest.AudioCallAnswerNoSetupOrConnection
[  FAILED  ] SignalingTest.FullCallRealTrickle
[  FAILED  ] SignalingTest.FullCallRealTrickleTestServer

1000ms still passes.
Attachment #8428503 - Flags: review?(rjesup) → review+
Comment on attachment 8428504 [details] [diff] [review]
match Fake_MediaStreamListener::NotifyPull time advances to timer period and Fake_AudioStreamSource::Periodic buffer size

Review of attachment 8428504 [details] [diff] [review]:
-----------------------------------------------------------------

Please fold these patches for checkin.  Thanks!
Attachment #8428504 - Flags: review?(rjesup) → review+
GUD JOB
https://hg.mozilla.org/mozilla-central/rev/9e1590531e5c
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla32
Blocks: 1023697
You need to log in before you can comment on or make changes to this bug.