Closed Bug 1015829 Opened 6 years ago Closed 6 years ago

libav/ffmpeg runtime binding for 53, 54 and 55

Categories

(Core :: Audio/Video, defect)

x86_64
Linux
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla33

People

(Reporter: ajones, Assigned: ajones)

Details

Attachments

(1 file, 2 obsolete files)

Add support for libavformat versions 53, 54 and 55 being linked dynamically at runtime.
This bug is related to this one? http://www.kdenlive.org/mantis/view.php?id=3292
(In reply to Zéfling from comment #2)
> This bug is related to this one?
> http://www.kdenlive.org/mantis/view.php?id=3292

No relation whatsoever. Firefox uses libvpx to decode WebM and also libav support is pref'ed off by default. The current release builds (including 29) use gstreamer for MP4 and MP3 support.
Attachment #8428513 - Attachment is obsolete: true
Comment on attachment 8444860 [details] [diff] [review]
Runtime binding for libav 53, 54, 55

Review of attachment 8444860 [details] [diff] [review]:
-----------------------------------------------------------------

A couple nits, but nice overall.

::: content/media/fmp4/ffmpeg/FFmpegDataDecoder.cpp
@@ +21,1 @@
>                                       AVCodecID aCodecID)

nit: whitespace here and elsewhere.

::: content/media/fmp4/ffmpeg/FFmpegRuntimeLinker.cpp
@@ +63,5 @@
>    }
>  
> +  printf_stderr("H264/AAC codecs unsupported without [");
> +  for (size_t i = 0; i < ArrayLength(sLibs); i++) {
> +    printf_stderr("%s %s", i ? "," : "", sLibs[i].Name);

LOG macros, plzkthx, so it can be switched on/off with NSPR_LOG_MODULES.
Attachment #8444860 - Flags: review?(edwin) → review+
Needed to separate out FFmpegLog.h and FFmpegLog.cpp
Attachment #8449055 - Flags: review?(edwin)
Attachment #8444860 - Attachment is obsolete: true
https://hg.mozilla.org/mozilla-central/rev/fddd3aa60b52
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla33
You need to log in before you can comment on or make changes to this bug.