Closed Bug 1015871 Opened 6 years ago Closed 6 years ago

Wrong uint32_t type when reading the number of touch events in nsGuiEventIPC.h

Categories

(Core :: DOM: Events, defect)

x86_64
Linux
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla32

People

(Reporter: vingtetun, Assigned: vingtetun)

Details

Attachments

(1 file)

Trying to turn on APZ on my desktop 64-bits linux machine, touch events were not dispatched properly.

The issue is because the code was written for a 32-bits architecture, and what was written to forward the touch events from the parent to the child process via IPC differs from what is read.
The issue comes from nsTArray.Length() returning a size_t value when writing the number of events, while the code that reads them expect a uint32_t value.
Assignee: nobody → 21
Attachment #8428590 - Flags: review?(bugs)
Attachment #8428590 - Flags: review?(bugs) → review+
This push hit desktop B2G mochitest failures. Not knowing the interdependencies of the push, I backed the entire thing out.
https://hg.mozilla.org/integration/mozilla-inbound/rev/616163ca1aa5

https://tbpl.mozilla.org/php/getParsedLog.php?id=41052634&tree=Mozilla-Inbound
And regular B2G.
https://tbpl.mozilla.org/php/getParsedLog.php?id=41054490&tree=Mozilla-Inbound

Please run this through Try before attempting to push to production again.
https://hg.mozilla.org/mozilla-central/rev/d9267032650f
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla32
You need to log in before you can comment on or make changes to this bug.