Closed Bug 1015949 Opened 8 years ago Closed 8 years ago

mulet's package doesn't contain b2g specifics

Categories

(Firefox OS Graveyard :: Runtime, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: ochameau, Assigned: ochameau)

References

Details

Attachments

(2 files)

When building `package` target on mulet, you get a Firefox tarball, without any b2g specific being explicitely listed in:
  http://mxr.mozilla.org/mozilla-central/source/b2g/installer/package-manifest.in

We need to ship those files in mulet packages!
Attached patch patchSplinter Review
https://tbpl.mozilla.org/?tree=Try&rev=80c20c7d5ca9

This patch removed the b2g.js pref file hack from browser/
Instead we now ensure preprocessing, building and shipping this file from b2g/dev/app/ and b2g/installer/.

And I added a reference to b2g package-manifest from browser's Makefile.
I had to toggle MOZ_PKG_FATAL_WARNING to 0 as b2g manifest has many duplicated files with Firefox one.
Assignee: nobody → poirot.alex
Attachment #8428771 - Flags: review?(fabrice)
Comment on attachment 8428771 [details] [diff] [review]
patch

Review of attachment 8428771 [details] [diff] [review]:
-----------------------------------------------------------------

lgtm, but I would not mind a second pair of eyes here.
Attachment #8428771 - Flags: review?(fabrice) → review+
Attachment #8428771 - Flags: review?(mshal)
Comment on attachment 8428771 [details] [diff] [review]
patch

Looks good to me too.
Attachment #8428771 - Flags: review?(mshal) → review+
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/8331da4219d8
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
I forgot to git add this file before submitting the patch...
Attachment #8431821 - Flags: review?(mshal)
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Attachment #8431821 - Flags: review?(mshal) → review+
I don't have try run as attachment 8431821 [details] [diff] [review] is mulet specific and mulet isn't built yet.
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/c387f539ede2
Status: REOPENED → RESOLVED
Closed: 8 years ago8 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
You need to log in before you can comment on or make changes to this bug.