1015975 - [Single Variant] Data value is not preserved after being changed by the user during the FTE

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Build, defect)

Description

[rafael.marquez]

*Pre-requisites
Having a variant.json file configured for our mnc/mcc with a line similar to: "data_ftu": false
Having a configured sim with pin inserted in the device

*Procedure
1. Flash the device with a single variant build
2. Press next button in language screen
3. Insert the pin code and press OK button
4. Change data value to "enable" before customization process is launched
5. Wait 10 second while customization process is launched

*Expected Result
Data value continues as "enabled" because if the user changes this parameter, the customization process doesn't change the value

*Actual Result
Data value is changed to "disabled" because the customization process does not verify that the user has changed the parameter

Comment 1

[Carmen Jimenez Cabezas]

Attachment: Proposed patch v1

Comment 2

[Francisco Jordano [:arcturus] [:francisco]]

Comment on attachment 8438750 [details] [review]
Proposed patch v1

Hi Fer,

can you take the review?

Thanks!

Comment 3

[Fernando Campo (:fcampo)]

Comment on attachment 8438750 [details] [review]
Proposed patch v1

...aaaand another one working good :)

Code good, travis green, works on device.
just a rewording of a variable for proper english, and we can merge.

Comment 4

[Carmen Jimenez Cabezas]

https://github.com/mozilla-b2g/gaia/commit/b871aa51c0885a979f6da10942aa5b04613770f8

Comment 5

[Carmen Jimenez Cabezas]

Requesting blocking 2.0 because without this users decision can be modified without their consent

Comment 6

[Ryan VanderMeulen [:RyanVM]]

v2.0: https://github.com/mozilla-b2g/gaia/commit/5699e1bff6d73e5331ff9faf48bf61103dd5415c

Comment 7

[rafael.marquez]

Verified in 2.0

Comment 8

[Coler]

Hi Rafael,
    Could you provide the "variant.json file" to help verify this issue on Flame 2.1? Thanks!

Comment 9

[Marcelino Veiga Tuimil [:sonmarce]]

All customization information is documented in https://developer.mozilla.org/en-US/Firefox_OS/Developing_Gaia/Market_customizations_guide

Comment 10

[Carmen Jimenez Cabezas]

We used this repository:
https://github.com/telefonicaid/firefoxos-gaia-testsbuild
for testing SingleVariant cases