Closed Bug 1015975 Opened 9 years ago Closed 9 years ago

[Single Variant] Data value is not preserved after being changed by the user during the FTE

Categories

(Firefox OS Graveyard :: Gaia::Build, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::Build
Platform:
Other
Other
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(blocking-b2g:2.0+, b2g-v2.0 verified, b2g-v2.1 fixed)

Status:
VERIFIED FIXED
Milestone:
2.0 S4 (20june)
Project Flags:
blocking-b2g 2.0+
Tracking Flags:
Tracking Status
b2g-v2.0 --- verified
b2g-v2.1 --- fixed

People

(Reporter: rafael.marquez, Assigned: macajc)

References

Details

(Whiteboard: [systemsfe])

Attachments

(1 file)

Proposed patch v1
46 bytes, text/x-github-pull-request
fcampo
: review+
Details | Review 
*Pre-requisites
Having a variant.json file configured for our mnc/mcc with a line similar to: "data_ftu": false
Having a configured sim with pin inserted in the device

*Procedure
1. Flash the device with a single variant build
2. Press next button in language screen
3. Insert the pin code and press OK button
4. Change data value to "enable" before customization process is launched
5. Wait 10 second while customization process is launched

*Expected Result
Data value continues as "enabled" because if the user changes this parameter, the customization process doesn't change the value

*Actual Result
Data value is changed to "disabled" because the customization process does not verify that the user has changed the parameter
Whiteboard: [systemsfe]
Depends on: 1022741
Attached file Proposed patch v1 — 

        Attachment #8438750 -
        Flags: review?(francisco)

    
    

    
  
Comment on attachment 8438750 [details] [review]
Proposed patch v1

Hi Fer,

can you take the review?

Thanks!

        Attachment #8438750 -
        Flags: review?(francisco) → review?(fernando.campo)

    
    

    
  
Comment on attachment 8438750 [details] [review]
Proposed patch v1

...aaaand another one working good :)

Code good, travis green, works on device.
just a rewording of a variable for proper english, and we can merge.

        Attachment #8438750 -
        Flags: review?(fernando.campo) → review+

    
    

    
  
https://github.com/mozilla-b2g/gaia/commit/b871aa51c0885a979f6da10942aa5b04613770f8
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED

    
    

    
  
Requesting blocking 2.0 because without this users decision can be modified without their consent
blocking-b2g: --- → 2.0?
blocking-b2g: 2.0? → 2.0+

    
    

    
  
v2.0: https://github.com/mozilla-b2g/gaia/commit/5699e1bff6d73e5331ff9faf48bf61103dd5415c
Assignee: nobody → cjc

          status-b2g-v2.0:
          --- → fixed

          status-b2g-v2.1:
          --- → fixed
Target Milestone: --- → 2.0 S4 (20june)

    
    

    
  
Verified in 2.0
Status: RESOLVED → VERIFIED

    
    

    
  
Hi Rafael,
    Could you provide the "variant.json file" to help verify this issue on Flame 2.1? Thanks!

          status-b2g-v2.0:
          fixed → verified
Flags: needinfo?(rafael.marquez)

    
    

    
  
All customization information is documented in https://developer.mozilla.org/en-US/Firefox_OS/Developing_Gaia/Market_customizations_guide
Flags: needinfo?(rafael.marquez)

    
    

    
  
We used this repository:
https://github.com/telefonicaid/firefoxos-gaia-testsbuild
for testing SingleVariant cases

          You need to log in
          before you can comment on or make changes to this bug.