1015995 - Add /resources to top nav and move /resources/home to /resources

Status: RESOLVED FIXED

(Webmaker Graveyard :: webmaker.org, defect)

Description

[inactivate account for kate]

current /resources should get added to the gallery

Comment 1

[Cassie McDaniel [:cassiemc]]

Reassigning to Ali since Kate is away this week.

Comment 2

[Ali Al Dallal [:alicoding]]

Aki, it will be really helpful if you could provide some information about how resoures page is being build. I just don't know where this going to be added because I don't really have an idea which index/navigation.html file is going to be if it is an Angular or nunjucks app.

Comment 3

[Aki Rose Braun [:akirose]]

So, before she left [:k88hudson] managed to make some changes to the Angular app within webmaker.org to set it to html5 mode (which I have no idea what that means exactly, but I get the impression it means it works with the history API to feel a lot more native?) 

As a result, right now, the WIP v2 resources page is built into our angular side and is living at /resources/home, but should ultimately live at /resources/

Does this answer your questions?

Comment 4

[inactivate account for kate]

I'll finish this up today

Comment 6

[inactivate account for kate]

Attachment: https://github.com/mozilla/webmaker.org/pull/756

Comment 7

[Ali Al Dallal [:alicoding]]

Comment on attachment 8430469 [details] [review]
https://github.com/mozilla/webmaker.org/pull/756

R+ - This is good, but need rebasing.

Comment 8

[[github robot]]

Commit pushed to master at https://github.com/mozilla/webmaker.org

https://github.com/mozilla/webmaker.org/commit/0bdf1670a9b149d3cd1fa6498e1d94562c5c046a
Bug 1015995 - Add /resources to top nav and move /resources/home to /resources