Closed Bug 1016000 Opened 8 years ago Closed 7 years ago

Remove uses of arguments.callee in /mail (except /mail/test/*)

Categories

(Thunderbird :: General, defect)

defect
Not set
trivial

Tracking

(thunderbird36 fixed)

RESOLVED FIXED
Thunderbird 36.0
Tracking Status
thunderbird36 --- fixed

People

(Reporter: aceman, Assigned: aceman)

References

()

Details

Attachments

(1 file, 1 obsolete file)

7.85 KB, patch
mkmelin
: review+
Details | Diff | Splinter Review
Remove uses of arguments.callee in /mail (except /mail/test/*) as it is not allowed in Javascript strict mode. This poses no problem yet, but may prevent unnecessary warnings/failure in the future if strict mode is turned on globally.

https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Functions_and_function_scope/Strict_mode

Seamonkey already doesn't use it.
Attached patch patch (obsolete) — Splinter Review
Attachment #8428918 - Flags: review?(mkmelin+mozilla)
You can just do something like this instead:

  Services.obs.addObserver(function myFunction(aSubject, aTopic, aData) {
    // ...
    Services.obs.removeObserver(myFunction, "update-staged");
  }, "update-staged", false);
Comment on attachment 8428918 [details] [diff] [review]
patch

Review of attachment 8428918 [details] [diff] [review]:
-----------------------------------------------------------------

Yeah I'd too prefer in-lining the functions
Attachment #8428918 - Flags: review?(mkmelin+mozilla) → review-
Attached patch patch v2Splinter Review
OK.
Attachment #8428918 - Attachment is obsolete: true
Attachment #8492630 - Flags: review?(mkmelin+mozilla)
Comment on attachment 8492630 [details] [diff] [review]
patch v2

Review of attachment 8492630 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM!
Attachment #8492630 - Flags: review?(mkmelin+mozilla) → review+
Thanks.
Keywords: checkin-needed
https://hg.mozilla.org/comm-central/rev/59a68078e67b
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 36.0
You need to log in before you can comment on or make changes to this bug.