1016000 - Remove uses of arguments.callee in /mail (except /mail/test/*)

Status: RESOLVED FIXED

(Thunderbird :: General, defect)

Description

[:aceman]

Remove uses of arguments.callee in /mail (except /mail/test/*) as it is not allowed in Javascript strict mode. This poses no problem yet, but may prevent unnecessary warnings/failure in the future if strict mode is turned on globally.

https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Functions_and_function_scope/Strict_mode

Seamonkey already doesn't use it.

Comment 1

[:aceman]

Attachment: patch

Comment 2

[Jim Porter (:squib)]

You can just do something like this instead:

  Services.obs.addObserver(function myFunction(aSubject, aTopic, aData) {
    // ...
    Services.obs.removeObserver(myFunction, "update-staged");
  }, "update-staged", false);

Comment 3

[Magnus Melin [:mkmelin]]

Comment on attachment 8428918 [details] [diff] [review]
patch

Review of attachment 8428918 [details] [diff] [review]:
-----------------------------------------------------------------

Yeah I'd too prefer in-lining the functions

Comment 4

[:aceman]

Attachment: patch v2

OK.

Comment 5

[Magnus Melin [:mkmelin]]

Comment on attachment 8492630 [details] [diff] [review]
patch v2

Review of attachment 8492630 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM!

Comment 6

[:aceman]

Thanks.

Comment 7

[Patrick Cloke [:clokep]]

https://hg.mozilla.org/comm-central/rev/59a68078e67b