1016050 - jpm should include an option to run the Add-on debugger

Status: RESOLVED FIXED

(Add-on SDK Graveyard :: General, defect, P2)

Description

[Will Bamberg [:wbamberg]]

At the moment working with the Add-on Debugger and cfx is cumbersome. I need to call cfx run, then when the browser is up go to Tools/Add-ons, switch to "Extensions", click "Debug", and confirm the warning dialog.

It would be great if I could just do something like "cfx run --debug" and have the debugger launched automatically.

This might be a better fit for JPM than cfx though.

Comment 1

[Jeff Griffiths (:canuckistani) (:⚡︎)]

This is an awesome idea. Let's confine it to jpm though, we have no intention of releasing another version of cfx.

Comment 2

[Matteo Ferretti [:zer0] [:matteo]]

+1!

Comment 3

[Jeff Griffiths (:canuckistani) (:⚡︎)]

I still think this is an awesome idea, but it should not block releasing jpm beta.

Comment 4

[Erik Vold [:erikvold] (please needinfo? me)]

Can I implement this in the addon/runner module, as the last step?  basically I would check if the load command was "run" and the "debug" option was provided, then open the debugger.

Another option is to do this in the bootstrap, or as a Fx cmd line arg

Comment 5

[Irakli Gozalishvili [:irakli] [:gozala] [@gozala]]

(In reply to Erik Vold [:erikvold] [:ztatic] from comment #4)
> Can I implement this in the addon/runner module, as the last step? 
> basically I would check if the load command was "run" and the "debug" option
> was provided, then open the debugger.
> 
> Another option is to do this in the bootstrap, or as a Fx cmd line arg

I think FX CMD line sounds best of all, although there maybe some caveats. I'll leave it up to your judgment to  decide which option will work the best, either one sound reasonable.

Comment 6

[Erik Vold [:erikvold] (please needinfo? me)]

Attachment: Link to Github pull-request: https://github.com/mozilla/addon-sdk/pull/1604

Comment 7

[Erik Vold [:erikvold] (please needinfo? me)]

Attachment: Link to Github pull-request: https://github.com/mozilla/jpm/pull/159

Comment 8

[Jordan Santell [:jsantell] [@jsantell]]

Comment on attachment 8481867 [details] [review]
Link to Github pull-request: https://github.com/mozilla/jpm/pull/159

r+ with the comments in the PR addressed (clarify help description for `--debug` and add the command option in the README)

Comment 9

[[github robot]]

Commits pushed to master at https://github.com/mozilla/addon-sdk

https://github.com/mozilla/addon-sdk/commit/712e356edf42b570b4500ba15bb985288d2e2cc9
Bug 1016050 - jpm should include an option to run the Add-on debugger

https://github.com/mozilla/addon-sdk/commit/d9b147bf4a2ae86e3b53ef329b3c31683cefa151
Merge pull request #1604 from erikvold/1016050

Bug 1016050 - jpm should include an option to run the Add-on debugger r=@jsantell