Closed
Bug 101608
Opened 23 years ago
Closed 23 years ago
Traceback tables should remain on for Mac OS X release builds
Categories
(SeaMonkey :: Build Config, defect, P2)
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla0.9.6
People
(Reporter: sfraser_bugs, Assigned: jj.enser)
References
Details
(Whiteboard: 10/10 needs r=, sr=, [PDT+] and [OSX+])
Attachments
(6 files)
573 bytes,
patch
|
Details | Diff | Splinter Review | |
949 bytes,
patch
|
sdagley
:
review+
|
Details | Diff | Splinter Review |
843 bytes,
patch
|
sdagley
:
review+
sfraser_bugs
:
superreview+
|
Details | Diff | Splinter Review |
872 bytes,
patch
|
sdagley
:
review+
sfraser_bugs
:
superreview+
|
Details | Diff | Splinter Review |
5.26 KB,
text/plain
|
Details | |
10.48 KB,
text/plain
|
Details |
We should leave traceback tables on for Mac OS X release builds, otherwise we have no way to get info about crashes (since we have no Talkback).
Comment 1•23 years ago
|
||
nsbranch+, we want this in our next release.
Keywords: nsbranch+
Priority: -- → P2
Whiteboard: 9/28 need fix and eventual PDT+ and OSX+
Target Milestone: --- → mozilla0.9.5
Assignee | ||
Comment 2•23 years ago
|
||
The same IDE_Options.h file is used for Classic & Carbon builds, so if we leave traceback option turned on, it will affects both builds. is that ok ?
Status: NEW → ASSIGNED
Reporter | ||
Comment 3•23 years ago
|
||
How about #if TARGET_CARBON?
Comment 4•23 years ago
|
||
not blocking 0.9.5, moving to 0.9.6
Target Milestone: mozilla0.9.5 → mozilla0.9.6
Assignee | ||
Comment 5•23 years ago
|
||
Updated•23 years ago
|
Whiteboard: 9/28 need fix and eventual PDT+ and OSX+ → 9/28 need fix and eventual PDT+, [OSX+]
Comment 6•23 years ago
|
||
jj, you need to make that a unified diff with a few lines of context. Use the Advanced Diff option in MacCVS Pro
Assignee | ||
Comment 7•23 years ago
|
||
Fine, I'll post a context diff even though this one is pretty straightforward :-/ seeking review for the patch to IDE_Options. This needs to land on the 0.9.4 branch first, then everywhere else. note: I have an equivalent patch for ns/build/mac/IDE_Options.h. I suppose both are needed
Whiteboard: 9/28 need fix and eventual PDT+, [OSX+] → 10/10 needs r=, sr=, PDT+ and OSX+
Assignee | ||
Comment 8•23 years ago
|
||
Reporter | ||
Comment 9•23 years ago
|
||
Please left-align the #ifdef TARGET_CARBON. And it should be #if TARGET_CARBON
Comment 10•23 years ago
|
||
Comment 11•23 years ago
|
||
Comment on attachment 52955 [details] [diff] [review] Additional patch required to make the #if TARGET_CARBON test work in IDE_Options.h r=sdagley w/smfr's changes. You'll also need the patch I attached or the #if TARGET_CARBON test will always fail in IDE_Options.h
Attachment #52955 -
Flags: review+
Comment 12•23 years ago
|
||
Comment on attachment 52945 [details] [diff] [review] Same patch as above, but as "unified diff" This is the one I meant to r=
Attachment #52945 -
Flags: review+
Reporter | ||
Comment 13•23 years ago
|
||
Comment on attachment 52955 [details] [diff] [review] Additional patch required to make the #if TARGET_CARBON test work in IDE_Options.h This is wrong. IDE_Options.h has to come after DefinesMac.h.
Attachment #52955 -
Flags: needs-work+
Comment 14•23 years ago
|
||
um, that's what patch 52955 does
Comment 15•23 years ago
|
||
Never mind, I can't read
Reporter | ||
Comment 16•23 years ago
|
||
Comment on attachment 52955 [details] [diff] [review] Additional patch required to make the #if TARGET_CARBON test work in IDE_Options.h I suck, this is OK.
Attachment #52955 -
Flags: needs-work+ → superreview+
Updated•23 years ago
|
Whiteboard: 10/10 needs r=, sr=, PDT+ and OSX+ → 10/10 needs r=, sr=, [PDT+] and [OSX+]
Assignee | ||
Comment 17•23 years ago
|
||
Assignee | ||
Comment 18•23 years ago
|
||
Simon, Steve, please add your respective r/sr marks for latest patch (attachment 53030 [review])
Comment 19•23 years ago
|
||
Comment on attachment 53030 [details] [diff] [review] rev#3 of the patch to IDE_Options.h with Simon's comments r=sdagley
Attachment #53030 -
Flags: review+
Reporter | ||
Comment 20•23 years ago
|
||
Comment on attachment 53030 [details] [diff] [review] rev#3 of the patch to IDE_Options.h with Simon's comments Fix the spacing, and sr=sfraser
Attachment #53030 -
Flags: superreview+
Assignee | ||
Comment 21•23 years ago
|
||
fixed. patches checked in to: mozilla/build/mac/IDE_Options.h mozilla/config/mac/NGLayoutConfigInclude.h ns/build/mac/IDE_Options.h
Status: ASSIGNED → RESOLVED
Closed: 23 years ago
Resolution: --- → FIXED
Comment 22•23 years ago
|
||
I'd suggest this go in on the 094 branch as well as the trunk. Also on the 095 branch if you can get drivers approval (and explain to them we get no debug info on OS X release builds if they balk at taking it)
Reporter | ||
Comment 24•23 years ago
|
||
To verify: make the build crash somehow(?), and look at the crash reporter report. It should give function names in the report, rather than just hex values.
Comment 25•23 years ago
|
||
To clarify how one gets a CrashReporter report, assuming Mac OS X 10.1, run the Console application (found in Applications/Utilities). Select the Preferences... item from the Console menu, click the Crashes tab in the prefs dialog, enable the checkboxes for Log crash information & Automatically display crash logs.
Comment 26•23 years ago
|
||
http://bugzilla.mozilla.org/show_bug.cgi?id=102727 is a way to crash on OS X. Petersen - I don't have OS X.1 (w/crash reporter installed). Can you verify the crash on OSX branch builds to make sure the stack trace shows function names instead of hex values? If so, then this bug report is verified.
QA Contact: lchiang → petersen
Comment 27•23 years ago
|
||
Comment 28•23 years ago
|
||
I have verified this is fixed in the 094 branch 2001-10-19 builds. Used bug 101868 to generate the crash. The log file shows the function names. Still need to verify on trunk so will leave this bug not yet marked verified.
Keywords: vtrunk
Comment 29•23 years ago
|
||
Updated•20 years ago
|
Product: Browser → Seamonkey
You need to log in
before you can comment on or make changes to this bug.
Description
•