1016148 - A/V Sync broken after seek in new MP4 demuxer

Status: RESOLVED FIXED

(Core :: Audio/Video, defect)

Description

[Chris Pearce [:cpearce (Not reading bugmail)]]

STR:

1. Make sure Nightly is up to date.
2. Pref on new demuxer, media.fragmented-mp4.exposed = true
3. Load http://people.mozilla.org/~cpearce/video/avatar.mp4
4. Seek somewhere into the video. Note that the audio is no longer in sync with the video.

Comment 1

[Chris Pearce [:cpearce (Not reading bugmail)]]

This is on Windows 8.1, in case that's not clear.

Comment 2

[Anthony Jones (:ajones, :kentuckyfriedtakahe, :k17e)]

Seems to work fine on Linux.

Comment 3

[Chris Pearce [:cpearce (Not reading bugmail)]]

This is a bug in the WMF PDM.

Comment 4

[Chris Pearce [:cpearce (Not reading bugmail)]]

Attachment: Patch 1: Rename WMFOutputSource to MFTManager

Since the WMFOutputSource also handles input now, it doesn't really make sense for it to be called and "output source", so rename it to MFTManager.

Comment 5

[Chris Pearce [:cpearce (Not reading bugmail)]]

Attachment: Patch 2: Mark samples after seek as discontinuities

The problem was that the MFT doesn't automatically mark samples after a seek as a discontinuity, so we have to do it manually. This meant the timestamps were wrong, which was messing up the A/V sync.

Comment 6

[Chris Pearce [:cpearce (Not reading bugmail)]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/47ff2362d955
https://hg.mozilla.org/integration/mozilla-inbound/rev/2dfa46ff5eca

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/47ff2362d955
https://hg.mozilla.org/mozilla-central/rev/2dfa46ff5eca