1016161 - Flush prefs on handling a locale change event

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Locale switching and selection, defect)

Description

[Richard Newman [:rnewman]]

Just in case Gecko doesn't. We should add

  Services.prefs.savePrefFile(null);

to browser.js, around line 1637.

Comment 1

[Richard Newman [:rnewman]]

Attachment: Flush prefs on handling a locale change event. v1

Comment 2

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 8437418 [details] [diff] [review]
Flush prefs on handling a locale change event. v1

If we need to, we need to. Looks like we need to.

But keep bug 683808 in mind.

Comment 3

[Richard Newman [:rnewman]]

This is only called when you actively select a new locale, so it shouldn't affect any fast paths.

We want this to be as close to a synchronous persistent prefs write as possible, because we only tell Gecko the new locale once. I've seen rapid hard quits on a low-end device lose the 'written' pref, which is a bad experience -- you have to switch locales again to get the change to stick.

Comment 4

[Richard Newman [:rnewman]]

https://hg.mozilla.org/integration/fx-team/rev/f2213f0c8362

Comment 5

[Richard Newman [:rnewman]]

Comment on attachment 8437418 [details] [diff] [review]
Flush prefs on handling a locale change event. v1

[Approval Request Comment]
Bug caused by (feature/regressing bug #): 
  Robustness improvement for Bug 917480.

User impact if declined: 
  Certain edge cases (e.g., OOM shortly after changing locale) can result in mixed locales between Gecko and Java.

Testing completed (on m-c, etc.): 
  Tested locally, landed and waiting for screams.

Risk to taking this patch (and alternatives if risky): 
  Approximately zero. Flushing the prefs file might cause stalls, but this is a very infrequent user action.

String or IDL/UUID changes made by this patch:
  None.

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/f2213f0c8362

Comment 7

[Lawrence Mandel [:lmandel] (use needinfo)]

Comment on attachment 8437418 [details] [diff] [review]
Flush prefs on handling a locale change event. v1

Aurora approval granted.

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/beb8b71d7b9a