Closed Bug 1016227 Opened 10 years ago Closed 10 years ago

[Collection] Update icon when apps or background changes

Categories

(Firefox OS Graveyard :: Gaia, defect)

Product:
Firefox OS Graveyard
Component:
Gaia
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(feature-b2g:2.0, tracking-b2g:backlog, b2g-v2.0 verified, b2g-v2.1 verified, b2g-v2.2 verified)

Status:
VERIFIED FIXED
Milestone:
2.0 S4 (20june)
Project Flags:
feature-b2g 2.0
tracking-b2g backlog
Tracking Flags:
Tracking Status
b2g-v2.0 --- verified
b2g-v2.1 --- verified
b2g-v2.2 --- verified

People

(Reporter: amirn, Assigned: kgrandon)

References

Details

(Whiteboard: [systemsfe])

Attachments

(1 file, 1 obsolete file)

Github pull request
46 bytes, text/x-github-pull-request
daleharvey
: review+
bajaj
: approval-gaia-v2.0+
Details | Review 
1. when locale changes
2. when (pinned or web) apps change
3. when bg changes

cf. homecreen implementation in https://github.com/mozilla-b2g/gaia/blob/master/apps/homescreen/everything.me/modules/Collection/Collection.js#L213
Depends on: 1016226
Blocks: collection-app
No longer depends on: 1016226
Blocks: 1016228
blocking-b2g: --- → backlog
feature-b2g: --- → 2.0
Whiteboard: [systemsfe]
Depends on: 1016226
Assignee: nobody → amirn
Target Milestone: --- → 2.0 S3 (6june)
No longer blocks: 1016228
Target Milestone: 2.0 S3 (6june) → 2.0 S4 (20june)
QA Whiteboard: [VH-FL-blocking+][VH-FC-blocking+]
Peter, we are still blocked.
Don't think we can get it done by 6/20
Assignee: amirn → nobody
Flags: needinfo?(pdolanjski)
What's the difference between this one and bug 1016221?
Flags: needinfo?(pdolanjski) → needinfo?(amirn)
This bug is about updating the homescreen icons of Collection when their data changes (app ordering and background)

bug 1016221 is about providing and using local assets as background images for *pre-installed* collections.

sorry for not being clear enough.
Flags: needinfo?(amirn)
Summary: [Collection App] Update Collection icons on Homescreen → [Collection] Update icon when apps or background changes
hope this patch can help, it's something I did real quick and was not tested
Amir - that patch is awesome, thanks for all the help on this.

I'm going to land, with tests if possible, if not we will add integration tests to cover it in the future.
Assignee: nobody → kgrandon
Status: NEW → ASSIGNED
Attached file Github pull request — 
Work in progress.
Attachment #8443412 - Attachment is obsolete: true
Attachment #8443687 - Flags: review?(dale)
Comment on attachment 8443687 [details] [review]
Github pull request

This is working good for me
Attachment #8443687 - Flags: review?(dale) → review+
So this is certainly not perfect, and could perform much better, but this is a start.

Landed: https://github.com/mozilla-b2g/gaia/commit/4bd74cef2d3865cca001896a86d291fb3f9f344f
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Comment on attachment 8443687 [details] [review]
Github pull request

Needed for the vertical homescreen.
Attachment #8443687 - Flags: approval-gaia-v2.0?(bbajaj)
Attachment #8443687 - Flags: approval-gaia-v2.0?(bbajaj) → approval-gaia-v2.0+
Keywords: verifyme
Flags: in-moztrap?(jlorenzo)
Verified the issue is fixed on 2.2, 2.1 and 2.0
Smart collection icon is updated when changing order of applications,
Note: Changing wallpaper background is no longer available

Device: Flame 2.2 Master KK
BuildID: 20141028040202
Gaia: 6a7fb482a03c5083ef79b41e7b0dfab27527cd04
Gecko: a255a234946e
Gonk: 6e51d9216901d39d192d9e6dd86a5e15b0641a89
Version: 36.0a1 (2.2 Master)
Firmware: V188
User Agent: Mozilla/5.0 (Mobile; rv:36.0) Gecko/36.0 Firefox/36.0

Device: Flame 2.1
BuildID: 20141028001203
Gaia: a0174f7166745256aaca1cb3aa9f894033fbffa6
Gecko: 43bda3541f6b
Gonk: 6e51d9216901d39d192d9e6dd86a5e15b0641a89
Version: 34.0 (2.1)
Firmware: V188
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0

Device: Flame 2.0
BuildID: 20141028000202
Gaia: 5e532a84e762b1bb6231756182cf1465671a061e
Gecko: 124f0bed1700
Gonk: 6e51d9216901d39d192d9e6dd86a5e15b0641a89
Version: 32.0 (2.0)
Firmware: V188
User Agent: Mozilla/5.0 (Mobile; rv:32.0) Gecko/32.0 Firefox/32.0
Status: RESOLVED → VERIFIED
status-b2g-v2.0: fixed → verified
status-b2g-v2.1: fixed → verified
Flags: needinfo?(ktucker)
Keywords: verifyme
QA Whiteboard: [VH-FL-blocking+][VH-FC-blocking+] → [VH-FL-blocking+][VH-FC-blocking+][QAnalyst-Triage?]
QA Whiteboard: [VH-FL-blocking+][VH-FC-blocking+][QAnalyst-Triage?] → [VH-FL-blocking+][VH-FC-blocking+][QAnalyst-Triage+]
status-b2g-v2.2: --- → verified
Flags: needinfo?(ktucker)
blocking-b2g: backlog → ---
tracking-b2g: --- → backlog
Flags: in-moztrap?(jlorenzo)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: