1016242 - Make adding review comments keyboard friendly

Status: RESOLVED INCOMPLETE

(bugzilla.mozilla.org :: Splinter, enhancement, P5)

Description

[Marco Zehe (:MarcoZ)]

Right now, if I review a patch, I have to use my screen reader's mouse emulation and perform a physical double-click to insert review comments into a patch when using the newer Review mode. This is cumbersome and can be error-prone, as the mouse is not always routed exactly where it is supposed to. I therefore propose:

Add the functionality to press Enter on a line to do the same as double-clicking it to add a review comment. To do this:

1. Add a tabindex="-1" to each line number and patch text snippet to make them keyboard focusable, but not include them in the tab order so as to not clutter up tabbing. that way, if I traverse a patch's table with a screen reader, keyboard focus follows where I am.
2. Add a keypress handler that reacts to the Enter key and does the same as a double-click. That way, I could then just press enter on the line or text that I want to comment on, be brought to the comment text field, add the comment, tab to save, and continue my review.

Comment 1

[Marco Zehe (:MarcoZ)]

Dylan, is Splinter going to stick around for longer, or should we close this at some point since everything is going to be replaced by Phabricator or whatever anyway?

Comment 2

[Dylan Hardison [:dylan] (he/him)]

There's no plan for continuing work on splinter.

This bug is P5, which means that we're not going to work on it, but a patch would be accepted. 

At some point Splinter will be EOL'd and then this would be WONTFIX, but there is no timeline for that just yet.

Comment 3

[Kohei Yoshino [:kohei]]

Splinter is retiring.