1016260 - Reftest analyzer doesn't label images as test or reference

Status: RESOLVED FIXED

(Testing :: Reftest, defect)

Description

[Kartikaya Gupta (email:[e-mail])]

For == reftests, the reftest analyzer just shows the expected and actual images as "Image 1" and "Image 2" and it's not obvious which is which. They should be labelled.

Comment 1

[Kartikaya Gupta (email:[e-mail])]

Attachment: Label images based on the log output

Comment 2

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 8429142 [details] [diff] [review]
Label images based on the log output

>+    <input id="radio1" type="radio" name="which" value="0" onchange="show_image(1)" checked="checked" /><label id="label1" title="1" for="radio1">Image 1</label>
>+    <input id="radio2" type="radio" name="which" value="1" onchange="show_image(2)" />                  <label id="label2" title="2" for="radio2">Image 2</label>

If you want to line things up here, please put the space inside the empty tag (i.e., before "/>") rather than adding substantive whitespace to the document.

r=dbaron with that

Comment 3

[Kartikaya Gupta (email:[e-mail])]

Adjusted spaces and landed:

https://hg.mozilla.org/integration/mozilla-inbound/rev/ffb294d03408

Comment 4

[Tim Taubert [:ttaubert] (inactive)]

https://hg.mozilla.org/mozilla-central/rev/ffb294d03408