Closed Bug 1016327 Opened 6 years ago Closed 6 years ago

[Vertical Homescreen] Home button is broken

Categories

(Firefox OS Graveyard :: Gaia::Homescreen, defect)

All
Gonk (Firefox OS)
defect
Not set

Tracking

(b2g-v2.0 fixed)

RESOLVED FIXED
2.0 S3 (6june)
Tracking Status
b2g-v2.0 --- fixed

People

(Reporter: crdlc, Assigned: kgrandon)

References

Details

(Keywords: regression, Whiteboard: [systemsfe])

Attachments

(1 file)

Assignee: nobody → crdlc
Status: NEW → ASSIGNED
Depends on: 1008020
Keywords: regression
Attached file Github pull request
Thanks for the review
Attachment #8429228 - Flags: review?(kgrandon)
Cristian, IMO the real issue is that homebutton taps are forwarded to the homescreen. I filed bug 1016334.
Thanks.
The real issue was that the variable homescreenFocused was not initialized
Yes, of course :)

I meant that once bug 1016334 is fixed, we will not need to handle the state of the homebutton at all. IMO it should be handled by the system app.
STR:

1. Launch the homescreen
2. Scroll down the list of apps
3. Click on home button 

Expected: reach the top of the homescreen.

Result: nothing happens
This tries to fix the current behavior. If in the future this changes, perfect, I agree. But we need that it works properly right now

(In reply to Amir Nissim (Everything.me) from comment #4)
> Yes, of course :)
> 
> I meant that once bug 1016334 is fixed, we will not need to handle the state
> of the homebutton at all. IMO it should be handled by the system app.
Sorry, I had to rebase some patches, and I guess I messed this one up =/ 

Would be good to add a test for this if possible - but I can do that in a follow-up.
Comment on attachment 8429228 [details]
Github pull request

Easy enough, thank you.
Attachment #8429228 - Flags: review?(kgrandon) → review+
Landed your patch: https://github.com/mozilla-b2g/gaia/commit/15d34cc2ed1960396de46b0cb609f1b1f57ebbd6

I'm going to steal and get a unit test in.
Assignee: crdlc → kgrandon
Landed a simple follow-up for a unit test: https://github.com/mozilla-b2g/gaia/commit/0e46099b1f4b923f4734518e85e70f754428cf9e
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Whiteboard: [systemsfe]
Target Milestone: --- → 2.0 S3 (6june)
Mass modify - set status-b2g-v2.0 fixed for fixed bugs under vertical homescreen dependency tree.
You need to log in before you can comment on or make changes to this bug.