Closed
Bug 1016339
Opened 11 years ago
Closed 11 years ago
indexing tasks should take class paths--not classes--as args
Categories
(Input Graveyard :: Code Quality, defect)
Input Graveyard
Code Quality
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: willkg, Assigned: willkg)
Details
(Whiteboard: u=dev c=codequality p=1 s=input.2014q2)
The indexing tasks take classes as arguments which means that when we change those classes, things get goofed up when we deploy for some number of tasks.
It'd be better to pass class paths (e.g. "fjord.search.models:Record") as arguments instead of classes. That way we can change the code for those classes and it's more likely to not result in failed celery tasks.
| Assignee | ||
Comment 1•11 years ago
|
||
Doing this right now. It's an easy fix and it gets it off my todo list.
Assignee: nobody → willkg
| Assignee | ||
Comment 2•11 years ago
|
||
| Assignee | ||
Comment 3•11 years ago
|
||
Landed in master i nhttps://github.com/mozilla/fjord/commit/8967350
| Assignee | ||
Comment 4•11 years ago
|
||
Pushed to prod just now.
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Updated•9 years ago
|
Product: Input → Input Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•