Closed Bug 1016342 Opened 10 years ago Closed 10 years ago

build translation by default

Categories

(Firefox :: Translations, defect)

Product:
Firefox
Component:
Translations
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
VERIFIED FIXED
Milestone:
Firefox 32

People

(Reporter: florian, Assigned: florian)

Details

(Whiteboard: [translation] p=1 s=it-32c-31a-30b.3 [qa-])

Attachments

(1 file)

Patch
3.42 KB, patch
Felipe
: review+
Details | Diff | Splinter Review
Attached patch Patch — — Splinter Review 
With bug 1003117 now resolved, I think there's no reason left to not build the browser/components/translation folder by default on mozilla-central.

After making this change the feature is still pref'ed off.

The attached patch also fixes the tests that are broken since bug 1013861 landed.

Try push: https://tbpl.mozilla.org/?tree=Try&rev=7339418bd26b
Attachment #8429245 - Flags: review?(felipc)
Assignee: nobody → florian
Status: NEW → ASSIGNED
Flags: firefox-backlog+
Comment on attachment 8429245 [details] [diff] [review]
Patch

Review of attachment 8429245 [details] [diff] [review]:
-----------------------------------------------------------------

Awesome! Preemptive r+ for the patch, but let's wait for a Go from Gavin to land it.
Attachment #8429245 - Flags: review?(felipc) → review+
Flags: needinfo?(gavin.sharp)
go for it
Flags: needinfo?(gavin.sharp)
Whiteboard: [translation] p=1 → [translation] p=1 s=it-32c-31a-30b.3 [qa?]
Whiteboard: [translation] p=1 s=it-32c-31a-30b.3 [qa?] → [translation] p=1 s=it-32c-31a-30b.3 [qa-]
https://hg.mozilla.org/mozilla-central/rev/fa11a3abecac
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 32
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: