Closed Bug 1016366 Opened 10 years ago Closed 10 years ago

Tiles in new tab page are too small on higher resolutions

Categories

(Firefox :: New Tab Page, defect)

defect
Not set
normal

Tracking

()

RESOLVED WONTFIX
Tracking Status
firefox30 --- unaffected
firefox31 - wontfix
firefox32 - wontfix

People

(Reporter: bugzilla, Unassigned)

References

Details

(Keywords: regression, uiwanted)

Attachments

(3 files)

Attached image Current new tab page
Build ID: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.9; rv:32.0) Gecko/20100101 Firefox/32.0

Nightly builds new tab page added a search bar, but it also made the tiles much smaller resulting in lots of unused white space. See attached screenshots.
Attached image New "new tab" page
What this bug requests is to make better use of the screen in higher resolutions like older versions of Firefox.
Blocks: 978338
Status: UNCONFIRMED → NEW
Ever confirmed: true
Keywords: regression
OS: Mac OS X → All
Hardware: x86 → All
Dão did this ever present differently in previous versions on hi-dpi screens?  It looks like this is an enhancement request more than a regression unless it did and if so, how far back?
Flags: needinfo?(dao)
Just compare the screenshots to see how it looked before in hi-dpi screens. This is a regression since it used to work well, but not anymore since bug 978338 was checked in.
According to bug 978338, this is potentially a regression in Firefox 31. Given the possibility of regression, I'm flagging this for tracking 31. I'd like to get to the bottom of the expected result of the change in bug 978338.

Cornel - You represented QA on bug 978338. Can you comment on how that bug was verified given the finding in this bug? Is the smaller page expected for some reason?
Flags: needinfo?(cornel.ionce)
Flags: needinfo?(dao)
The smaller page is expected because the tiles have a fixed ratio now (243x150 px) as you may see in bug 975208 (attachment https://bug975208.bugzilla.mozilla.org/attachment.cgi?id=8385835). I'm afraid this is not going to change due to this fact.

As a workaround, you could change the default number of rows/columns in order to see more tiles and so, you won't have so much unused space, with the following prefs from about:config
- browser.newtabpage.columns
- browser.newtabpage.rows
Flags: needinfo?(cornel.ionce)
(In reply to Cornel Ionce [QA] from comment #6)
> The smaller page is expected because the tiles have a fixed ratio now
> (243x150 px) as you may see in bug 975208 (attachment
> https://bug975208.bugzilla.mozilla.org/attachment.cgi?id=8385835). I'm
> afraid this is not going to change due to this fact.

This only explains why technically the tiles are smaller. I would like to know from a UX point of view why this change would be better.
Keywords: uiwanted
Flags: needinfo?(jboriss)
Flags: firefox-backlog+
https://bug1030832.bugzilla.mozilla.org/attachment.cgi?id=8446620 is the spec for the new tiles design. Page 3 of that spec shows how larger screens will show more tiles, which can solve this bug.

We can implement the requested change of page 3 to fix this bug without having to implement the rest of the new Tiles design spec.
Blocks: 1030832
Flags: needinfo?(jboriss)
Attached patch PatchSplinter Review
Based on the spec that I linked to in the earlier comment, we want to show more tabs when space permits.

I looked in to removing the preference values at first, since they are less useful now but that will affect add-ons that are referencing them and also removes the ability for people to limit the number of tiles that are displayed on the New Tab Page.

We will now show up to 15 tiles on the New Tab Page (5 columns, 3 rows) as is described by the spec. The search container now has a fixed max-width of 600px, and I put a 12px left and right margin on the search container to match the offset that the toggle button has from the top-right corner of the page (visible when the browser window is made very narrow).

The spec shows that a minimum of two columns will be shown when the browser window is < 640 pixels wide, but our tiles don't currently scale down when the viewport is narrower. This would mean that we would need to be OK with showing a horizontal scrollbar, which I'm pretty sure we don't want. In the case that the browser window is very narrow (320px for example), we will show a single column of tiles.
Assignee: nobody → jaws
Status: NEW → ASSIGNED
Attachment #8449028 - Flags: review?(adw)
Added to Iteration 33.2  
Jared, can you provide a point value and if the bug should be marked as [qa+] or [qa-]
Iteration: --- → 33.2
QA Whiteboard: {qa?]
QA Whiteboard: {qa?] → [qa?]
Whiteboard: p=2
QA Whiteboard: [qa?] → [qa+]
Doing a little bugzilla switcharoo here. This bug is now being marked as wontfix as the size of the tiles are by design and we aren't planning on changing them in v1.

Bug 1026561 will be unduped and will be used for the patch that I just attached (v2 will tweak the size of the tiles but since we will probably want to uplift this patch I went with a reduced approach to reduce the potential effects on telemetry experiments and QA risk.
Assignee: jaws → nobody
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → WONTFIX
Iteration: 33.2 → ---
QA Whiteboard: [qa+]
Flags: firefox-backlog+ → firefox-backlog-
Whiteboard: p=2
No longer blocks: 1030832
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: