1016377 - [NFC] NfcManager.handleTechnologyDiscovered should properly handle malformed messages

Status: RESOLVED FIXED

(Firefox OS Graveyard :: NFC, defect)

Description

[Krzysztof Mioduszewski[:tauzen]]

NfcManager.handleTechologyDiscovered(command) is a message handler for 'nfc-manager-tech-discovered' message. If the message will not be an object containing techList array this method will throw the following errors:
- "TypeError: command is null", if message is null
- "TypeError: techList is undefined", if message does not contain techList property
- "TypeError: techList.sort is not a function", if techList is not an array (actually this is thrown in different method, which expects to get an array as an argument)

This message originates from nfc_worker.js and is passed to Nfc.js which after some modifications sends it to NfcManager. I think we should assume that somewhere on the processing path the message might be malformed. Also i would propose to rename command to be consistent with the naming in lower layers.

Comment 1

[Krzysztof Mioduszewski[:tauzen]]

Attachment: pull-request-1016377.txt

Comment 2

[Carsten Book [:Tomcat]]

master: https://github.com/mozilla-b2g/gaia/commit/d42c6abc29e90d0985d260f538e453f516d05b22