Closed Bug 1016423 Opened 10 years ago Closed 10 years ago

Use Hawk for making authenticated HTTP requests and support FxA assertions

Categories

(Firefox OS Graveyard :: Gaia::Loop, defect)

ARM
Gonk (Firefox OS)
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: jaoo, Assigned: jaoo)

References

Details

Attachments

(1 file)

Hawk is being added to the Loop server in bug 1000782 so let's add it to the FxOS loop client app as well.
Assignee: nobody → josea.olivera
Blocks: Loopmov_1_1
Depends on: 1000782
Depends on: 984949
Summary: Use Hawk for making authenticated HTTP requests → Use Hawk for making authenticated HTTP requests and support FxA assertions
Depends on: 1019564
Depends on: 1023296
Depends on: 1023792
Comment on attachment 8430742 [details] [review]
Pointer to Github PR https://github.com/mozilla-b2g/firefoxos-loop-client/pull/10

Hey Borja, this is ready. Could you have a look at it please? Thanks!
Attachment #8430742 - Flags: review?(borja.bugzilla)
Comment on attachment 8430742 [details] [review]
Pointer to Github PR https://github.com/mozilla-b2g/firefoxos-loop-client/pull/10

Antonio, I added the 'Part 4' commit with the script we need for packaging and moving the app to the outoftree_apps/ Gaia folder. Could you have a look at it please? Thanks!
Attachment #8430742 - Flags: feedback?(amac)
Comment on attachment 8430742 [details] [review]
Pointer to Github PR https://github.com/mozilla-b2g/firefoxos-loop-client/pull/10

Left a couple of comments on the PR, mostly so we don't forget to fix that.
Attachment #8430742 - Flags: feedback?(amac) → feedback+
Comment on attachment 8430742 [details] [review]
Pointer to Github PR https://github.com/mozilla-b2g/firefoxos-loop-client/pull/10

Some comments in the PR. Please let me know when ready and I'll take a look asap! Thanks!
Attachment #8430742 - Flags: review?(borja.bugzilla)
Comment on attachment 8430742 [details] [review]
Pointer to Github PR https://github.com/mozilla-b2g/firefoxos-loop-client/pull/10

Ready, lets discuss if needed.
Attachment #8430742 - Flags: review?(borja.bugzilla)
Comment on attachment 8430742 [details] [review]
Pointer to Github PR https://github.com/mozilla-b2g/firefoxos-loop-client/pull/10

Let's merge this!
Attachment #8430742 - Flags: review?(borja.bugzilla) → review+
(In reply to Borja Salguero (this week part-time in Gaia) [:borjasalguero] from comment #7)
> Comment on attachment 8430742 [details] [review]
> Pointer to Github PR
> https://github.com/mozilla-b2g/firefoxos-loop-client/pull/10
> 
> Let's merge this!

Thanks, landed at:

https://github.com/mozilla-b2g/firefoxos-loop-client/commit/b257e5f659bcb37a7eb22933b3f9e359ae3c61b3
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: