1016431 - [System] Fix unit tests with a newer mocha

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::System, defect)

Description

[Julien Wajsberg [:julienw]]

In Bug 874510, we try to upgrade mocha and we faced some issues in existing tests.

In System, here are the failing tests:

 15) [system-test/unit/fxa_test/screens/fxam_set_password_test.js] Screen: Set password > onNext > Sign up working:

Error: timeout of 10000ms exceeded

at (anonymous) (http://system.gaiamobile.org:8080/common/vendor/mocha/mocha.js:4254:5)

Comment 1

[Julien Wajsberg [:julienw]]

By catching the error in that test, here is more information:

     Uncaught Error: TypeError: gotoNextStepCallback is not a function (http://system.gaiamobile.org:8080/fxa/js/screens/fxam_set_password.js?time=1401987419613:120)


Borja, I think you're the one who wrote this test, can you please have a look ?

You can take the pull request at https://github.com/mozilla-b2g/gaia/pull/19330, and relaunch the test-agent if it's already launched.

Comment 2

[Borja Salguero [:borjasalguero]]

I'll take this bug. I've seen that this is not scoped for v2.0, could you confirm that? I would like to know the priority of this because we are running a lot of things in parallel. On the other hand, I'll try to take a look asap  (during next week). Thanks!

Comment 3

[Julien Wajsberg [:julienw]]

It's not scoped at all but upgrading mocha would enable good things for us:

* using promises in tests
* faster test runs

Comment 4

[Julien Wajsberg [:julienw]]

Attachment: github PR

Linearizing the test.

I'm quite sure this can bring intermittent even with current mocha, but new mocha makes this permared.

Comment 5

[Julien Wajsberg [:julienw]]

waited one more day for Borja's review, but well, pushed :)

master: 14a996d62755bc8751811ad6f82ac82e49d91521