1016448 - Add Mulet to tbpl

Status: RESOLVED FIXED

(Tree Management Graveyard :: TBPL, defect)

Description

[Armen [:armenzg]]

We can put it under "B2g Desktop" for now.

Comment 1

[Armen [:armenzg]]

The builder looks like this:
linux64-mulet_fig_dep

We should see the testers pop up a bit later.

See it in here:
https://tbpl.mozilla.org/?tree=Fig

Comment 2

[Armen [:armenzg]]

We're going to aim for Firefox style branch names:
Linux Mulet x86-64 <branch> build
Ubuntu VM 12.04 x64 Mulet <branch> test <suite>

Comment 3

[Ryan VanderMeulen [:RyanVM]]

I believe you meant the below for the build :)
Linux x86-64 Mulet %(branch) build

And to close the loop, other platforms:

Linux Mulet <branch> build
Ubuntu VM 12.04 Mulet <branch> test <suite>

OSX Mulet <branch> build
OSX Mulet <branch> test <suite>

Windows Mulet <branch> build
Windows Mulet <branch> test <suite>

Comment 4

[Ryan VanderMeulen [:RyanVM]]

Actually, we should probably have the OS version in the test jobs (not the builds, though). I'm going to use OSX 10.8 and Windows 8 as the assumed test platforms for any eventual jobs for now.

OSX 10.8 Mulet <branch> test <suite>
Windows 8 Mulet <branch> test <suite>

Comment 5

[Ryan VanderMeulen [:RyanVM]]

One more minor (and sorta-silly) change - going to use "OS X" instead of "OSX".

Comment 6

[Ryan VanderMeulen [:RyanVM]]

Attachment: Add Mulet build/test support to TBPL

This patch as-posted will *NOT* work with the current Linux64 Mulet builds on TBPL. It is based off the future job names discussed in comments 2-5. I did, however, write a version of this patch against the existing job name and confirmed that it works as expected.

While I was in here, I also added "dep" and "periodic" to the generic catch-all condition for builds so they don't get the ? treatment. I also removed Fedora from the Linux jobs as they've been dead for over a month now.

Comment 7

[Ed Morley [:emorley]]

Comment on attachment 8430098 [details] [diff] [review]
Add Mulet build/test support to TBPL

Review of attachment 8430098 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/Data.js
@@ +561,5 @@
>        // transitioned to the new bug 586664 form
>        var os =
>          // ** Linux **
>          /^b2g.*_(?:linux|ubuntu)64/.test(name) ? "b2g-linux64" :
> +        /^(?:linux|ubuntu).*64 Mulet/.test(name) ? "mulet-linux64" :

This doesn't have the case-insensitive switch, so won't match against Linux/Ubuntu. We either need the case insenstive option, or else (my preferred choice) capitalise Linux/Ubuntu.

@@ +729,5 @@
>          /non-unified/i.test(name) ? "Non-Unified Build" :
>          /static analysis/i.test(name) ? "Static Checking Build" :
>          /valgrind/i.test(name) ? "Valgrind Nightly" :
>          /dxr/i.test(name) ? "DXR Index Build" :
> +        /build|dep|periodic$/i.test(name) ? "Build" :

The end of line marker only applies to "periodic", which means trees like build-system will false-positive against this. Needs to use parens.

Comment 8

[Armen [:armenzg]]

Comment on attachment 8430098 [details] [diff] [review]
Add Mulet build/test support to TBPL

I wonder if going with "mulet-..." instead of "...-mulet" will cause me trouble.
I will give it a shot.

Comment 9

[Armen [:armenzg]]

Nvm, I think it's your own key inside of tbpl.

LGTM as-is.

Comment 10

[Ryan VanderMeulen [:RyanVM]]

Attachment: Add Mulet build/test support to TBPL

Updated to review comments.

Comment 11

[Ed Morley [:emorley]]

Comment on attachment 8431631 [details] [diff] [review]
Add Mulet build/test support to TBPL

Review of attachment 8431631 [details] [diff] [review]:
-----------------------------------------------------------------

ty :-)

Comment 12

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/webtools/tbpl/rev/7f4b59fa7114

Ready to rename whenever you're ready, Armen!

Comment 13

[Armen [:armenzg]]

I'm waiting for the positive review, land and reconfig :)
I will mention on the other bug.

Comment 14

[Ryan VanderMeulen [:RyanVM]]

In production :)