Closed Bug 1016492 Opened 10 years ago Closed 10 years ago

[B2G][Flame][Camera] - Working animation / spinner missing during the processing delay from taking a HDR picture.

Categories

(Firefox OS Graveyard :: Gaia::Camera, defect, P1)

ARM
Gonk (Firefox OS)
defect

Tracking

(Not tracked)

RESOLVED FIXED
2.0 S3 (6june)

People

(Reporter: jmitchell, Assigned: wilsonpage)

Details

(Keywords: perf, Whiteboard: [c=progress p= s=2014.06.06.t u=] interaction-design)

Attachments

(1 file)

Description:
This bug was created from the conversations of bug https://bugzilla.mozilla.org/show_bug.cgi?id=1007973

"The delay is due to processing intrinsic to the camera library. Unfortunately there is nothing we can do about it. I suggest the UI throw up a spinner or something similar, possibly with a "Processing..." message while this is going on."

Repro Steps:
1) Update a Flame to BuildID: 20140527013003
2) Load the Camera App
3) Turn on HDR
4) Take a picture

Actual:
 A delay of 4-6 seconds occur where everything appears to be frozen while the device processes the picture.
Expected:
 An animated spinner will show during this processing time to allow the user to know that everything is ok and that the phone is working.

Environmental Variables:
Device: Flame 2.0
BuildID: 20140527013003
Gaia: 6a391274cd436f8f0d1fad2db8c6b4805703259c
Gecko: cbe4f69c2e9c
Version: 32.0a1
Firmware Version: v10G-2

Repro frequency: 100%


This issue DOES NOT reproduce on the latest 2.0 build on Open-C; there is only a 1 second delay between pictures.

Environmental Variables:
Device: Open_C 
BuildID: 20140527013003
Gaia: 6a391274cd436f8f0d1fad2db8c6b4805703259c
Gecko: cbe4f69c2e9c
Version: 32.0a1
Firmware Version: P821A10V1.0.0B06_LOG_DL
Whiteboard: interaction-design
We either need to fix this for 1.4 or won't fix it. Given that this is a critical feature for 1.4 & 4 - 6 seconds is relatively long for a single picture, I'm leaning on the side of blocking here, as no user feedback for 4 - 6 seconds is going to confuse a user.
blocking-b2g: --- → 1.4?
Keywords: perf
Hema

Can we please help with reassign?
blocking-b2g: 1.4? → 1.4+
Flags: needinfo?(hkoka)
Priority: -- → P1
Whiteboard: interaction-design → interaction-design[c=progress p= s= u=1.4]
(In reply to Jason Smith [:jsmith] from comment #1)
> We either need to fix this for 1.4 or won't fix it. Given that this is a
> critical feature for 1.4 & 4 - 6 seconds is relatively long for a single
> picture, I'm leaning on the side of blocking here, as no user feedback for 4
> - 6 seconds is going to confuse a user.

This only happens on flame. As mentioned in the original bug: https://bugzilla.mozilla.org/show_bug.cgi?id=1007973, we can add the spinner for a better experience. The reason why the original bug was marked POVB is to see if vendor can help in any way to fix it. HDR is much faster in both Open C and Nexus4, the delay is on flame. 

Wilson or Justin, can one of pick this up for adding a spinner?

NI frlee to see if we can inform vendor about this issue with HDR and investigate on their end. 

Thanks
Hema
Flags: needinfo?(wilsonpage)
Flags: needinfo?(jdarcangelo)
Flags: needinfo?(frlee)
Flags: needinfo?(hkoka)
(In reply to Hema Koka [:hema] from comment #3)
> (In reply to Jason Smith [:jsmith] from comment #1)
> > We either need to fix this for 1.4 or won't fix it. Given that this is a
> > critical feature for 1.4 & 4 - 6 seconds is relatively long for a single
> > picture, I'm leaning on the side of blocking here, as no user feedback for 4
> > - 6 seconds is going to confuse a user.
> 
> This only happens on flame. As mentioned in the original bug:
> https://bugzilla.mozilla.org/show_bug.cgi?id=1007973, we can add the spinner
> for a better experience. The reason why the original bug was marked POVB is
> to see if vendor can help in any way to fix it. HDR is much faster in both
> Open C and Nexus4, the delay is on flame. 
> 
> Wilson or Justin, can one of pick this up for adding a spinner?
> 
> NI frlee to see if we can inform vendor about this issue with HDR and
> investigate on their end. 
> 
> Thanks
> Hema

I'm not sure why this would be a vendor issue though. This doesn't occur on 2.0 to my understanding, which makes this look like an issue more likely on our end.
(In reply to Jason Smith [:jsmith] from comment #4)
> (In reply to Hema Koka [:hema] from comment #3)
> > (In reply to Jason Smith [:jsmith] from comment #1)
> > > We either need to fix this for 1.4 or won't fix it. Given that this is a
> > > critical feature for 1.4 & 4 - 6 seconds is relatively long for a single
> > > picture, I'm leaning on the side of blocking here, as no user feedback for 4
> > > - 6 seconds is going to confuse a user.
> > 
> > This only happens on flame. As mentioned in the original bug:
> > https://bugzilla.mozilla.org/show_bug.cgi?id=1007973, we can add the spinner
> > for a better experience. The reason why the original bug was marked POVB is
> > to see if vendor can help in any way to fix it. HDR is much faster in both
> > Open C and Nexus4, the delay is on flame. 
> > 
> > Wilson or Justin, can one of pick this up for adding a spinner?
> > 
> > NI frlee to see if we can inform vendor about this issue with HDR and
> > investigate on their end. 
> > 
> > Thanks
> > Hema
> 
> I'm not sure why this would be a vendor issue though. This doesn't occur on
> 2.0 to my understanding, which makes this look like an issue more likely on
> our end.

Oh wait - disregard. I see now - the above testing was on Open C, so the delay does only happen on Flame.
I'm going to unblock this because this won't happen on any shipping device because the root cause of the delay is a vendor issue.
blocking-b2g: 1.4+ → ---
I can take this at some point. Assuming not urgent.
Flags: needinfo?(wilsonpage)
Assignee: nobody → wilsonpage
Attached file pull-request (master)
Attachment #8434110 - Flags: review?(dmarcos)
Comment on attachment 8434110 [details] [review]
pull-request (master)

Looks good! Ship it!
Attachment #8434110 - Flags: review?(dmarcos) → review+
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Whiteboard: interaction-design[c=progress p= s= u=1.4] → [c=progress p= s=2014.06.06.t u=] interaction-design
Target Milestone: --- → 2.0 S3 (6june)
Flags: needinfo?(frlee)
Flags: needinfo?(jdarcangelo)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: