1016496 - Logout does not ask for confirmation

Status: RESOLVED WONTFIX

(Firefox OS Graveyard :: FxA, defect, P3)

Description

[No-Jun Park [:njpark]]

STR:
Log in to firefox accounts
Log out from firefox accounts in Settings -> Firefox accounts dialog

Expected:
Per Bug 949100, the user should be presented with the confirmation dialog and a warning message.

Actual:
Logout is completed without any warning message.


Version Info:
│ Gaia      c8f6ba7aa9a694f5f691555a0d049f5630cdde3d                         │
│ Gecko                                                                      │
│ https://hg.mozilla.org/releases/mozilla-b2g28_v1_3t/rev/bde42427e332       │
│ BuildID   20140527014007                                                   │
│ Version   28.1                                                             │
│ ro.build.version.incremental=301

Comment 1

[bhavana bajaj [:bajaj]]

Minor, not a blocker.

Comment 3

[Jared Hirsch [:jhirsch] (he/him) (Needinfo please)]

Looks like this will require a little bit of Gecko work to land.

I've tried reusing the existing refreshAuthentication screen/IAC command, but if there's an active session, Gecko throws an ERROR_ALREADY_LOGGED_IN_USER without checking the password.

To be discussed with spenrose or ferjm when those guys are back from PTO.

Comment 4

[Fernando Jiménez Moreno [:ferjm]]

(In reply to Jared Hirsch [:_6a68] [@6a68] from comment #3)
> Looks like this will require a little bit of Gecko work to land.
> 
> I've tried reusing the existing refreshAuthentication screen/IAC command,
> but if there's an active session, Gecko throws an
> ERROR_ALREADY_LOGGED_IN_USER without checking the password.
> 
> To be discussed with spenrose or ferjm when those guys are back from PTO.

Hi Jared,

I believe in this case we shouldn't reuse the refreshAuthentication screen or its IAC command, but instead keep using the current 'logout' IAC command [1] and create a new logout screen (note that we already have a way to trigger such a screen via FxAccountsUI.logout [2] but we don't have the screen itself). Also note that the US at [3] is not specifying that the user should be asked to introduce any password but the description of [4] does, so this new screen should be able to provide both options.

As you said, it seems that we also need some Gecko work for [4] as we need to verify the password before logging the user out. I think that we can simply add the password to the FxAClient.logout call [5] and let Gecko do the verification. On the Gaia side we would need to listen for the 'onlogout' event [6].

[1] https://mxr.mozilla.org/gaia/source/apps/system/js/fxa_manager.js#81
[2] https://mxr.mozilla.org/gaia/source/apps/system/js/fxa_ui.js#31
[3] https://bugzilla.mozilla.org/show_bug.cgi?id=949100#c0
[4] https://bugzilla.mozilla.org/show_bug.cgi?id=1055249#c0
[5] https://mxr.mozilla.org/gaia/source/apps/system/js/fxa_client.js#85
[6] https://mxr.mozilla.org/gaia/source/apps/system/js/fxa_manager.js#168

Comment 5

[BMO Automation]

Firefox OS is not being worked on