1016767 - Modify test_imapID.js to use Promises

Status: RESOLVED FIXED

(MailNews Core :: Testing Infrastructure, defect)

Description

[Suyash Agarwal (:sshagarwal)]

test_imapID.js currently uses asynctestutils, we want it to use
Promises.

Comment 1

[Suyash Agarwal (:sshagarwal)]

Attachment: Patch v1

An attempt to convert this asyncUrlListener based test to use promises.

Comment 2

[Kent James (:rkent)]

Comment on attachment 8429751 [details] [diff] [review]
Patch v1

Review of attachment 8429751 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, r=me with nits fixed.

::: mailnews/imap/test/unit/test_imapID.js
@@ +3,5 @@
>   * Test to ensure that we handle the RFC2197 ID command.
>   */
>  
>  load("../../../resources/logHelper.js");
>  load("../../../resources/asyncTestUtils.js");

Delete this line, since we are no longer using asyncTestUtils.js

@@ +27,5 @@
> +  IMAPPump.inbox.updateFolderWithListener(null, promiseUrlListener);
> +  yield promiseUrlListener.promise;
> +});
> +
> +add_task(function* checkIDHandling() {

This function is not a generator, so it should be function check... not function* check...

Comment 3

[Suyash Agarwal (:sshagarwal)]

Attachment: Patch for check-in

Thanks.

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/comm-central/rev/7c14b91b3088