Closed Bug 1016816 Opened 10 years ago Closed 10 years ago

[CostControl] Update to use gaia-header

Categories

(Firefox OS Graveyard :: Gaia::Cost Control, defect)

x86
macOS
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: yor, Assigned: wilsonpage)

References

Details

Attachments

(1 file, 2 obsolete files)

46 bytes, text/x-github-pull-request
wilsonpage
: review+
Details | Review
      No description provided.
Blocks: gaia-header
Assignee: nobody → yor
Status: NEW → ASSIGNED
Attached file Pull Request (obsolete) —
Attachment #8431325 - Flags: review?(salva)
Attachment #8431325 - Flags: review?(21)
Comment on attachment 8431325 [details] [review]
Pull Request

Moving to JM.
Attachment #8431325 - Flags: review?(salva)
Attachment #8431325 - Flags: review?(jmcf)
Attachment #8431325 - Flags: review?(21)
Comment on attachment 8431325 [details] [review]
Pull Request

Apart from the comments on GH the position of the settings icon in the main header app is incorrect. Please check
Attachment #8431325 - Flags: review?(jmcf) → review-
Attached file pull-request (master) (obsolete) —
Attachment #8431325 - Attachment is obsolete: true
Attachment #8467153 - Flags: review?(jmcf)
Updated this patch to use the new shared setup.
Assignee: yor → wilsonpage
Attachment #8467153 - Flags: review?(jmcf) → review?(mri)
Comment on attachment 8467153 [details] [review]
pull-request (master)

After install the patch I can see the following errors on the console:

E/GeckoConsole(  790): [JavaScript Warning: "Unknown property 'speak'.  Declaration dropped." {file: "app://costcontrol.gaiamobile.org/shared/elements/gaia-icons/style.css" line: 21 column: 6 source: "	speak:none;"}]
E/GeckoConsole(  790): [JavaScript Warning: "Unknown property '-moz-osx-font-smoothing'.  Declaration dropped." {file: "app://costcontrol.gaiamobile.org/shared/elements/gaia-icons/style.css" line: 27 column: 24 source: "	-moz-osx-font-smoothing:grayscale;"}]

Please, addressing this here or openning a new bug to fix it.

r+ for me, please correct the nits on GH. Works well, thank you.
Attachment #8467153 - Flags: review?(mri) → review+
Depends on: 1024993
No longer depends on: 1024993
mai: I'm having issues with unit-tests. Can you try running locally and diagnose what's causing them to fail?
Flags: needinfo?(mri)
mai: Seems I managed to fix them :)
Flags: needinfo?(mri)
Depends on: 1036394
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Backed out for causing linter failures: https://github.com/mozilla-b2g/gaia/commit/a2219a55145e730e56e09527b40152d68a43b0d9

https://travis-ci.org/mozilla-b2g/gaia/jobs/32451857
Status: RESOLVED → REOPENED
Flags: needinfo?(yor)
Resolution: FIXED → ---
TBPL is currently down and trees are closed, but maybe we only have to update the xfail count here? I can help dig into this later today if you guys don't get to it.
Comment on attachment 8467153 [details] [review]
pull-request (master)

UPDATED

- Fixed CSSLint failure.

---

This was due to CSSLint recently being turned on on TBPL (after initial TBPL green). I'll wait for green and re-land.
Attached file pull-request (master)
Attachment #8467153 - Attachment is obsolete: true
Comment on attachment 8472449 [details] [review]
pull-request (master)

Carrying across previous r+
Attachment #8472449 - Flags: review+
Status: REOPENED → RESOLVED
Closed: 10 years ago10 years ago
Resolution: --- → FIXED
Flags: needinfo?(yor)
Blocks: 1054945
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: