Closed Bug 1016829 Opened 8 years ago Closed 8 years ago

[Tarako] Can't retrieve a MMS for SIM2 when SIM1 is empty.

Categories

(Firefox OS Graveyard :: RIL, defect)

ARM
Gonk (Firefox OS)
defect
Not set
normal

Tracking

(blocking-b2g:1.3T+, b2g-v1.3 wontfix, b2g-v1.3T verified, b2g-v1.4 fixed, b2g-v2.0 unaffected)

VERIFIED FIXED
2.0 S3 (6june)
blocking-b2g 1.3T+
Tracking Status
b2g-v1.3 --- wontfix
b2g-v1.3T --- verified
b2g-v1.4 --- fixed
b2g-v2.0 --- unaffected

People

(Reporter: julienw, Assigned: bevis)

References

Details

(Whiteboard: [sprd322573])

Attachments

(1 file)

STR:
1. have only one SIM in SIM2 (SIM1 is absent)
2. set "MMS Auto Retrieve" to off
3. send a MMS to the DuT on SIM2
4. wait that the MMS arrive
5. press "download" to retrieve the message

Expected:
* the message is downloaded and then displayed

Actual:
* we have an error "Missing SIM card"

(I haven't tried with the SIM in SIM1, nor with 2 SIMs, could be a job for QA).

Nominating because the scenario is likely.
Flags: needinfo?(btseng)
Thanks for providing more detailed STR for this.
I'll try to reproduce this locally to see what's going on. :)
Flags: needinfo?(btseng)
Assignee: nobody → btseng
Root cause found:
- Access to NULL reference to radioInterfaces[0].rilContext.iccInfo while comparing iccid in [1].

Luckily, this has been fixed while supporting to manual retrieve MMS only if
the SIM is matched in Bug 981077 after 1.4.

Hence, this only affects to 1.3/1.3t.

[1] http://hg.mozilla.org/releases/mozilla-b2g28_v1_3t/file/99d521214d74/dom/system/gonk/RadioInterfaceLayer.js#l998
Hi Hsinyi,

We implicitly fixed this problem after 1.4 while 
refactoring getClientIdByIccId() into MmsService in Bug 981077:
http://hg.mozilla.org/mozilla-central/rev/4009d99f1e07

This patch is just a quick fix for 1.3/1.3t branch instead of including the entire fix in Bug 981077 which defines new error for better UX.

This issue only happens while manually retreving MMS if 
SIM1 is empty and SIM2 is valid.
The root cause is NULL referencing while iterating radioInterfaces[i].rilContext.iccInfo in RadioInterfaceLayer.getClientIdByIccId().
Attachment #8429966 - Flags: review?(htsai)
Summary: [Tarako] Can't retrieve a MMS for SIM2 → [Tarako] Can't retrieve a MMS for SIM2 when SIM1 is empty.
Comment on attachment 8429966 [details] [diff] [review]
Patch v1: Prevent NULL referencing while iterating radioInterfaces[i].rilContext.iccInfo. r=htsai

Review of attachment 8429966 [details] [diff] [review]:
-----------------------------------------------------------------

Nice! Thank you.
Attachment #8429966 - Flags: review?(htsai) → review+
blocking-b2g: 1.3T? → 1.3+
1.3 issues specifically need to be cert blockers to block. Was the flag set correctly here?
blocking-b2g: 1.3+ → 1.3T?
Comment on attachment 8429966 [details] [diff] [review]
Patch v1: Prevent NULL referencing while iterating radioInterfaces[i].rilContext.iccInfo. r=htsai

NOTE: This flag is now for security issues only. Please see https://wiki.mozilla.org/Release_Management/B2G_Landing to better understand the B2G approval process and landings.

[Approval Request Comment]
Bug caused by (feature/regressing bug #): NA
User impact if declined: Not able to manually retrieve MMS from SIM 2, if SIM 2 inserted and SIM 1 is empty.
Testing completed: Y
Risk to taking this patch (and alternatives if risky): N
String or UUID changes made by this patch:N/A
Attachment #8429966 - Attachment description: Patch v1: Prevent NULL referencing while iterating radioInterfaces[i].rilContext.iccInfo. → Patch v1: Prevent NULL referencing while iterating radioInterfaces[i].rilContext.iccInfo. r=htsai
Attachment #8429966 - Flags: approval-mozilla-b2g28?
triage: 1.3T+ to take this for tarako
blocking-b2g: 1.3T? → 1.3T+
Holding off on this until the 1.3 vs. 1.3T blocking status question (comment 5) is sorted out. Note that 1.3 still merges to 1.3T, so landing on b2g28 will cover Tarako as well.
Keywords: checkin-needed
Joe and Vance, I think this is a blocker for 1.3 and 1.3T. What do you think?
Flags: needinfo?(vchen)
Flags: needinfo?(jcheng)
(In reply to Ken Chang[:ken] from comment #10)
> Joe and Vance, I think this is a blocker for 1.3 and 1.3T. What do you think?

I just need to know if it's a cert issue for 1.3. If it is, then we can block it for 1.3.
Not a cert blocker for TCL 1.3 projects
 
Thanks
Flags: needinfo?(vchen)
Let's just land it in 1.3T.
Keywords: checkin-needed
 https://hg.mozilla.org/releases/mozilla-b2g28_v1_3t/rev/1945abae19ff
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Attachment #8429966 - Flags: approval-mozilla-b2g28?
Flags: needinfo?(jcheng)
QA Contact: nhirata.bugzilla
Yang, please land this WIP patch and verify it.
Flags: needinfo?(yang.zhao)
Whiteboard: [sprd322573]
(In reply to James Zhang (Spreadtrum) from comment #15)
> Yang, please land this WIP patch and verify it.
Land it by using patch,the gerrit address is:http://review.source.spreadtrum.com/gitb2g/gerrit/#/c/1169/
Please help to merge it .
Flags: needinfo?(yang.zhao)
Flags: needinfo?(janjongboom)
Apparently this patch is not needed in 1.4 as per https://bugzilla.mozilla.org/show_bug.cgi?id=1016829#c2
Flags: needinfo?(janjongboom)
Jan, this comes from bug 1025399. But like you I'd like at least Bevis' feedback before moving forward.
Duplicate of this bug: 1025399
(In reply to Julien Wajsberg [:julienw] from comment #18)
> Jan, this comes from bug 1025399. But like you I'd like at least Bevis'
> feedback before moving forward.

I am very sorry for have wrong statement in comment 3. :(
After double confirmed, actually the fix of Bug 981077 was not landed in 1.4 but in 2.0 instead.
Hence, we still need to land this fix to 1.4.
(In reply to Julien Wajsberg [:julienw] from comment #18)
> Jan, this comes from bug 1025399. But like you I'd like at least Bevis'
> feedback before moving forward.

Thanks Julien for coordinating this. :-)
So Bevis, we'd need to ask an approval here, right ?
Comment on attachment 8429966 [details] [diff] [review]
Patch v1: Prevent NULL referencing while iterating radioInterfaces[i].rilContext.iccInfo. r=htsai

NOTE: This flag is now for security issues only. Please see https://wiki.mozilla.org/Release_Management/B2G_Landing to better understand the B2G approval process and landings.

[Approval Request Comment]
Bug caused by (feature/regressing bug #): NA
User impact if declined: Not able to manually retrieve MMS from SIM 2, if SIM 2 inserted and SIM 1 is empty. This is also afftected in 1.4 but we missed it.
Testing completed: Y
Risk to taking this patch (and alternatives if risky): N
String or UUID changes made by this patch:N/A
Attachment #8429966 - Flags: approval-mozilla-b2g30?
(In reply to Julien Wajsberg [:julienw] from comment #22)
> So Bevis, we'd need to ask an approval here, right ?

Thanks for reminding. I've fired the request.
Comment on attachment 8429966 [details] [diff] [review]
Patch v1: Prevent NULL referencing while iterating radioInterfaces[i].rilContext.iccInfo. r=htsai

needs to land on Dolphin branch
Attachment #8429966 - Flags: approval-mozilla-b2g30?
Whiteboard: [sprd322573] → [sprd322573][dolphin land]
Comment on attachment 8429966 [details] [diff] [review]
Patch v1: Prevent NULL referencing while iterating radioInterfaces[i].rilContext.iccInfo. r=htsai

NOTE: This flag is now for security issues only. Please see https://wiki.mozilla.org/Release_Management/B2G_Landing to better understand the B2G approval process and landings.

[Approval Request Comment]
Bug caused by (feature/regressing bug #): NA
User impact if declined: Not able to manually retrieve MMS from SIM 2, if SIM 2 inserted and SIM 1 is empty. This is also afftected in 1.4 but we missed it.
Testing completed: Y
Risk to taking this patch (and alternatives if risky): N
String or UUID changes made by this patch:N/A
Attachment #8429966 - Flags: approval-mozilla-b2g30?
Hi Lawrence,

Mind if you can check this bug for v1.4 uplift approval. Thanks you.
Flags: needinfo?(lmandel)
Adding a NI to Bhavana as she should be quicker to answer.
Flags: needinfo?(bbajaj)
Comment on attachment 8429966 [details] [diff] [review]
Patch v1: Prevent NULL referencing while iterating radioInterfaces[i].rilContext.iccInfo. r=htsai

Approved for 1.4.
Attachment #8429966 - Flags: approval-mozilla-b2g30? → approval-mozilla-b2g30+
Flags: needinfo?(lmandel)
Flags: needinfo?(bbajaj)
https://hg.mozilla.org/releases/mozilla-b2g30_v1_4/rev/6f8b310d40e2
Whiteboard: [sprd322573][dolphin land] → [sprd322573]
Target Milestone: --- → 2.0 S3 (6june)
You need to log in before you can comment on or make changes to this bug.