Closed Bug 1016849 Opened 5 years ago Closed 5 years ago

Remove isActive in nsITelephonyProvider

Categories

(Firefox OS Graveyard :: RIL, defect)

x86_64
Linux
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
2.0 S3 (6june)

People

(Reporter: aknow, Assigned: aknow)

References

Details

(Whiteboard: [p=2])

Attachments

(4 files, 4 obsolete files)

No description provided.
nsITelephonyProvider has redundant entries:
# boolean isActive is redundant with unsigned short callState
Attachment #8429917 - Flags: review?(htsai)
Attached patch Part 2: Remove isActive (dom) (obsolete) — Splinter Review
Attachment #8429918 - Flags: review?(htsai)
Ben,
We are going to remove 'isActive' from telephony interface. This field is not used and the same information could be determined from 'callState'.
Attachment #8429919 - Flags: review?(btian)
Attachment #8429921 - Flags: review?(htsai)
Comment on attachment 8429919 [details] [diff] [review]
Part 3: Remove isActive (bluetooth)

Review of attachment 8429919 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM. Thanks.
Attachment #8429919 - Flags: review?(btian) → review+
Attachment #8429917 - Flags: review?(htsai) → review+
Attachment #8429918 - Flags: review?(htsai) → review+
Comment on attachment 8429921 [details] [diff] [review]
Part 4: Remove isActive (provider)

Review of attachment 8429921 [details] [diff] [review]:
-----------------------------------------------------------------

Thank you!
Attachment #8429921 - Flags: review?(htsai) → review+
Attachment #8429918 - Attachment is obsolete: true
Attachment #8430601 - Flags: review+
Whiteboard: [p=2]
Blocks: 1000485
You need to log in before you can comment on or make changes to this bug.