Closed
Bug 1016849
Opened 5 years ago
Closed 5 years ago
Remove isActive in nsITelephonyProvider
Categories
(Firefox OS Graveyard :: RIL, defect)
Not set
Tracking
(Not tracked)
RESOLVED
FIXED
2.0 S3 (6june)
People
(Reporter: aknow, Assigned: aknow)
References
Details
(Whiteboard: [p=2])
Attachments
(4 files, 4 obsolete files)
|
12.72 KB,
patch
|
aknow
:
review+
|
Details | Diff | Splinter Review |
|
2.45 KB,
patch
|
aknow
:
review+
|
Details | Diff | Splinter Review |
|
1.94 KB,
patch
|
aknow
:
review+
|
Details | Diff | Splinter Review |
|
5.39 KB,
patch
|
aknow
:
review+
|
Details | Diff | Splinter Review |
No description provided.
|
Assignee | |
Comment 1•5 years ago
|
||
nsITelephonyProvider has redundant entries: # boolean isActive is redundant with unsigned short callState
|
|
Assignee | |
Comment 2•5 years ago
|
||
Attachment #8429917 -
Flags: review?(htsai)
|
|
Assignee | |
Comment 3•5 years ago
|
||
Attachment #8429918 -
Flags: review?(htsai)
|
|
Assignee | |
Comment 4•5 years ago
|
||
Ben, We are going to remove 'isActive' from telephony interface. This field is not used and the same information could be determined from 'callState'.
Attachment #8429919 -
Flags: review?(btian)
|
|
Assignee | |
Comment 5•5 years ago
|
||
Attachment #8429921 -
Flags: review?(htsai)
|
||
Comment 6•5 years ago
|
||
Comment on attachment 8429919 [details] [diff] [review] Part 3: Remove isActive (bluetooth) Review of attachment 8429919 [details] [diff] [review]: ----------------------------------------------------------------- LGTM. Thanks.
Attachment #8429919 -
Flags: review?(btian) → review+
|
||
Updated•5 years ago
|
Blocks: b2g-ril-interface
|
|
||
Updated•5 years ago
|
Attachment #8429917 -
Flags: review?(htsai) → review+
|
|
||
Updated•5 years ago
|
Attachment #8429918 -
Flags: review?(htsai) → review+
|
|
||
Comment 7•5 years ago
|
||
Comment on attachment 8429921 [details] [diff] [review] Part 4: Remove isActive (provider) Review of attachment 8429921 [details] [diff] [review]: ----------------------------------------------------------------- Thank you!
Attachment #8429921 -
Flags: review?(htsai) → review+
|
|
Assignee | |
Comment 8•5 years ago
|
||
Attachment #8429917 -
Attachment is obsolete: true
Attachment #8430600 -
Flags: review+
|
|
Assignee | |
Comment 9•5 years ago
|
||
Attachment #8429918 -
Attachment is obsolete: true
Attachment #8430601 -
Flags: review+
|
|
Assignee | |
Comment 10•5 years ago
|
||
Attachment #8429919 -
Attachment is obsolete: true
Attachment #8430602 -
Flags: review+
|
|
Assignee | |
Comment 11•5 years ago
|
||
Attachment #8429921 -
Attachment is obsolete: true
Attachment #8430604 -
Flags: review+
|
|
Assignee | |
Comment 12•5 years ago
|
||
https://tbpl.mozilla.org/?tree=Try&rev=0c945a2a13f1
Keywords: checkin-needed
|
||
Comment 13•5 years ago
|
||
https://hg.mozilla.org/integration/b2g-inbound/rev/eb1f34579ce6 https://hg.mozilla.org/integration/b2g-inbound/rev/e7c5b73bcb95 https://hg.mozilla.org/integration/b2g-inbound/rev/45fbee730e46 https://hg.mozilla.org/integration/b2g-inbound/rev/24c221634316
Keywords: checkin-needed
|
||
Comment 14•5 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/eb1f34579ce6 https://hg.mozilla.org/mozilla-central/rev/e7c5b73bcb95 https://hg.mozilla.org/mozilla-central/rev/45fbee730e46 https://hg.mozilla.org/mozilla-central/rev/24c221634316
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → 2.0 S3 (6june)
|
|
Assignee | |
Updated•5 years ago
|
Whiteboard: [p=2]
You need to log in
before you can comment on or make changes to this bug.
Description
•