1016853 - [Flame][V1.4][Phone]You can't make emergency calls(eg:110,119) after the SIM Card locked, but you can make emergency calls with no SIM Card

Status: RESOLVED INVALID

(Firefox OS Graveyard :: Vendcom, defect)

Description

[panda67231]

Attachment: 5630.rar

[1.Description]:
After the SIM card locked cannot make emergency calls（eg："110","119"）,but it can make emergency calls when not installed SIMcard.
Attach the Video. (locked card.mp4&no card.mp4)
Attach the logs. (bugreport_locked card.txt & logcat_locked card.txt&logcat_no card.txt)
Happen time:about16:00

[2.Testing Steps]: 
Precondition:There is a SIM card locked.
1.Power on device
**SIM Card PIN input box is shown.
2.Tap "skip"
3.Launch dialer keyboard.
4.Make an emergency  call "119".
**It will display "No network connection"
Note： if there is no simcard in device, these emergency call can be conneccted successfully.

[3.Expected Result]: 
4.It should be successful that MT an emergency call. 

[4.Actual Result]: 
4.It should fail that MTan emergency call. 

[5.Reproduction build]: 
Gaia        7709936aeb21859d1607dbd038489493803bb085
Gecko     https://hg.mozilla.org/releases/mozilla-b2g30_v1_4/rev/5bf038fae0f1
BuildID    20140522160202
Version    30.0

[6.Reproduction Frequency]: Always Recurrence,5/5

Comment 1

[Jason Smith [:jsmith]]

Cut & dry cert blocker. However, we can't do a regression study on this for obvious reasons.

Comment 2

[Preeti Raghunath(:Preeti)]

David,

Please review and reassign

Comment 3

[Doug Sherk (:drs) (inactive)]

I can't repro this, even with the exact STR. It's possible that we've uplifted something to v1.4 that fixed this since the report. Please try the STR again.

Comment 4

[panda67231]

Attachment: Verify1.3gp

We can repro it 100% on flame V1.4, please refer to the attached video:Verify1.3gp, thanks

Comment 5

[Jason Smith [:jsmith]]

Hubert - Can you check this on the latest 1.4?

Comment 6

[Hubert Lu[:hlu] <[e-mail]>]

This issue could be reproduced on the latest v1.4(BuildID:20140613000202）, but I need to update the behavior below.

For emergency call (119,110), it will have this issue that the call fail to dial out when SIM is locked.

But for emergency call (112, 911), the issue is NOT existed. No matter which case, the emergency call could dial out.

Comment 7

[Doug Sherk (:drs) (inactive)]

(In reply to Hubert Lu[:hlu] <[e-mail]> from comment #6)
> This issue could be reproduced on the latest v1.4(BuildID:20140613000202）,
> but I need to update the behavior below.
> 
> For emergency call (119,110), it will have this issue that the call fail to
> dial out when SIM is locked.
> 
> But for emergency call (112, 911), the issue is NOT existed. No matter which
> case, the emergency call could dial out.

Thanks. With the new STR, I'm able to repro this all the way up to master.

Comment 8

[Doug Sherk (:drs) (inactive)]

With the SIM card locked, we're passing in (phoneNumber, undefined) here:
https://github.com/mozilla-b2g/gaia/blob/v1.4/apps/communications/dialer/js/telephony_helper.js#L95

In the case of 119, it would be (119, undefined), and in the case of 112, it would be (112, undefined). As I said, I was able to repro the "no network" error for the phone numbers 119 and 110.

I tried passing in 0 and 1 as well and neither of these worked, so I believe this is a platform problem.

Hsin-Yi, can you take a look?

Comment 9

[Hsin-Yi Tsai (she/her) [:hsinyi]]

(In reply to Doug Sherk (:drs) from comment #8)
> With the SIM card locked, we're passing in (phoneNumber, undefined) here:
> https://github.com/mozilla-b2g/gaia/blob/v1.4/apps/communications/dialer/js/
> telephony_helper.js#L95
> 
> In the case of 119, it would be (119, undefined), and in the case of 112, it
> would be (112, undefined). As I said, I was able to repro the "no network"
> error for the phone numbers 119 and 110.
> 
> I tried passing in 0 and 1 as well and neither of these worked, so I believe
> this is a platform problem.
> 
> Hsin-Yi, can you take a look?

Sure. I'll get back to you later.

Comment 10

[Hsin-Yi Tsai (she/her) [:hsinyi]]

(In reply to Hsin-Yi Tsai [:hsinyi] from comment #9)
> (In reply to Doug Sherk (:drs) from comment #8)
> > With the SIM card locked, we're passing in (phoneNumber, undefined) here:
> > https://github.com/mozilla-b2g/gaia/blob/v1.4/apps/communications/dialer/js/
> > telephony_helper.js#L95
> > 
> > In the case of 119, it would be (119, undefined), and in the case of 112, it
> > would be (112, undefined). As I said, I was able to repro the "no network"
> > error for the phone numbers 119 and 110.
> > 
> > I tried passing in 0 and 1 as well and neither of these worked, so I believe
> > this is a platform problem.
> > 
> > Hsin-Yi, can you take a look?
> 
> Sure. I'll get back to you later.

The quick guess is 119 and 110 are not in the property ril.ecclist or ro.ril.ecclist. Hence, gecko sees only 911 and 112 (the default values) as valid emergency numbers. 

Please help check those properties set in your device, thanks!

Comment 11

[Hsin-Yi Tsai (she/her) [:hsinyi]]

(In reply to Hsin-Yi Tsai [:hsinyi] from comment #10)
> (In reply to Hsin-Yi Tsai [:hsinyi] from comment #9)
> > (In reply to Doug Sherk (:drs) from comment #8)
> > > With the SIM card locked, we're passing in (phoneNumber, undefined) here:
> > > https://github.com/mozilla-b2g/gaia/blob/v1.4/apps/communications/dialer/js/
> > > telephony_helper.js#L95
> > > 
> > > In the case of 119, it would be (119, undefined), and in the case of 112, it
> > > would be (112, undefined). As I said, I was able to repro the "no network"
> > > error for the phone numbers 119 and 110.
> > > 
> > > I tried passing in 0 and 1 as well and neither of these worked, so I believe
> > > this is a platform problem.
> > > 
> > > Hsin-Yi, can you take a look?
> > 
> > Sure. I'll get back to you later.
> 
> The quick guess is 119 and 110 are not in the property ril.ecclist or
> ro.ril.ecclist. Hence, gecko sees only 911 and 112 (the default values) as
> valid emergency numbers. 
> 
> Please help check those properties set in your device, thanks!

Okay, things seem different from my previous guess. Investigating ...

Comment 12

[Hsin-Yi Tsai (she/her) [:hsinyi]]

Attachment: log - ecclist with unlocked sim card inserted

grep -i XXX right after reboot.
ril.ecclist: "911, 112"

1-06 23:19:27.959 I/Gecko   (  289): -*- RadioInterfaceLayer: XXX rilEmergencyNumbers: "911,112"
01-06 23:19:27.959 I/Gecko   (  289): -*- RadioInterfaceLayer: XXX ril.ecclist: "911,112"
01-06 23:19:27.959 I/Gecko   (  289): -*- RadioInterfaceLayer: XXX ro.ril.ecclist: ""

Comment 13

[Hsin-Yi Tsai (she/her) [:hsinyi]]

Attachment: log - ecclist with locked sim card inserted

grep -i XXX right after reboot.

At first we got empty ril.ecclist
===
01-06 23:22:57.449 I/Gecko   (  289): -*- RadioInterfaceLayer: XXX rilEmergencyNumbers: ""
01-06 23:22:57.449 I/Gecko   (  289): -*- RadioInterfaceLayer: XXX ril.ecclist: ""
01-06 23:22:57.449 I/Gecko   (  289): -*- RadioInterfaceLayer: XXX ro.ril.ecclist: ""
===

eventually, we got ril.ecclist: "911, 112"
===
06-17 18:00:36.634 I/Gecko   (  289): -*- RadioInterfaceLayer: XXX dial - ril.ecclist: "911,112"
06-17 18:00:36.634 I/Gecko   (  289): -*- RadioInterfaceLayer: XXX dial - ro.ril.ecclist: ""
===

Comment 14

[Hsin-Yi Tsai (she/her) [:hsinyi]]

Attachment: log - ecclist without sim cards inserted

grep -i XXX after reboot.
ril.ecclist: "911,112,000,08,110,999,118,119"

01-06 23:25:00.409 I/Gecko   (  288): -*- RadioInterfaceLayer: XXX rilEmergencyNumbers: "911,112,000,08,110,999,118,119"
01-06 23:25:00.409 I/Gecko   (  288): -*- RadioInterfaceLayer: XXX ril.ecclist: "911,112,000,08,110,999,118,119"
01-06 23:25:00.409 I/Gecko   (  288): -*- RadioInterfaceLayer: XXX ro.ril.ecclist: ""

Comment 15

[Doug Sherk (:drs) (inactive)]

Fugu on boot with an unlocked SIM:
I/Gecko   ( 3894): -*- RadioInterface[boot / ril.ecclist]: 000,08,110,999,118,119,120,122,911,112

On boot with a locked SIM:
I/Gecko   (  118): -*- RadioInterface[boot / ril.ecclist]: 000,08,110,999,118,119,120,122,911,112

I was unable to repro this on Fugu.

Comment 16

[Francis Lee [:frlee]]

hi all,

can this issue be reproduced on Flame v1.3 v122 release?

hi Mike,

please kindly have a quick test when you go through v122 testing.

Comment 17

[Mike Lien[:mlien]]

verify with Flame v122 base image
results are the same with comment 13 and comment 14

Comment 18

[Francis Lee [:frlee]]

hi Yanan,

please check this issue. emergency call is not working when SIM is locked.

Comment 19

[Hsin-Yi Tsai (she/her) [:hsinyi]]

(In reply to Francis Lee [:frlee] from comment #18)
> hi Yanan,
> 
> please check this issue. emergency call is not working when SIM is locked.

ecclist isn't correct when SIM is inserted, no matter locked or not.
I also noticed there seems timing issue if gecko queries ecclist property quickly, gecko gets empty result as comment 13.

Comment 20

[Jason Smith [:jsmith]]

Over to Vendcom since this is a vendor bug.

Comment 21

[Hsin-Yi Tsai (she/her) [:hsinyi]]

Hi all, 

Some updates after talking to our partner.

ril.ecclist is provided from modem and the value varies with situations, such as the presence of SIM cards. So, it looks no problem with the current ecclist configurations. If specific emergency numbers are required, then that would be a customized issue, and out of the scope of reference phones here. Based on the above, I'll mark this as INVALID. Feel free to reopen it if you have different opinions.

More, note that there is still a valid timing issue that makes gecko not retrieve valid ecclist (as comment 19). Bug 1023141 is handling this.