1016854 - [Contacts] Intermittent MarionetteJS failure on Travis: Contacts > Delete > Edit menu is not visible on search mode: Error: timeout exceeded!

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Contacts, defect)

Description

[Julien Wajsberg [:julienw]]

This happens on master:


 3) Contacts > Delete > Edit menu is not visible on search mode:

Error: timeout exceeded!

at Object.Client.waitForSync (/home/travis/build/mozilla-b2g/gaia/node_modules/marionette-client/lib/marionette/client.js:682:16)

at Object.Client.waitFor (/home/travis/build/mozilla-b2g/gaia/node_modules/marionette-client/lib/marionette/client.js:650:60)

at Object.MarionetteHelper.waitForElement (/home/travis/build/mozilla-b2g/gaia/node_modules/marionette-helper/index.js:142:12)

at Object.onDisplayed (/home/travis/build/mozilla-b2g/gaia/apps/communications/contacts/test/marionette/delete_contacts_test.js:37:36)

at Object.Client._handleCallback (/home/travis/build/mozilla-b2g/gaia/node_modules/marionette-client/lib/marionette/client.js:484:23)

at /home/travis/build/mozilla-b2g/gaia/node_modules/marionette-client/lib/marionette/client.js:510:21

at TcpSync.send (/home/travis/build/mozilla-b2g/gaia/node_modules/marionette-client/lib/marionette/drivers/tcp-sync.js:100:10)

at Object.send (/home/travis/build/mozilla-b2g/gaia/node_modules/marionette-client/lib/marionette/client.js:457:36)

at Object.Client._sendCommand (/home/travis/build/mozilla-b2g/gaia/node_modules/marionette-client/lib/marionette/client.js:503:19)

at Object.Element._sendCommand (/home/travis/build/mozilla-b2g/gaia/node_modules/marionette-client/lib/marionette/element.js:49:21)

at Object.displayed (/home/travis/build/mozilla-b2g/gaia/node_modules/marionette-client/lib/marionette/element.js:287:19)

at Context.<anonymous> (/home/travis/build/mozilla-b2g/gaia/apps/communications/contacts/test/marionette/delete_contacts_test.js:32:14)

at callFn (/home/travis/build/mozilla-b2g/gaia/node_modules/mocha/lib/runnable.js:223:21)

at Test.Runnable.run (/home/travis/build/mozilla-b2g/gaia/node_modules/mocha/lib/runnable.js:216:7)

at Runner.runTest (/home/travis/build/mozilla-b2g/gaia/node_modules/mocha/lib/runner.js:374:10)

at /home/travis/build/mozilla-b2g/gaia/node_modules/mocha/lib/runner.js:452:12

at next (/home/travis/build/mozilla-b2g/gaia/node_modules/mocha/lib/runner.js:299:14)

at /home/travis/build/mozilla-b2g/gaia/node_modules/mocha/lib/runner.js:309:7

at next (/home/travis/build/mozilla-b2g/gaia/node_modules/mocha/lib/runner.js:247:23)

at /home/travis/build/mozilla-b2g/gaia/node_modules/mocha/lib/runner.js:271:7

at done (/home/travis/build/mozilla-b2g/gaia/node_modules/mocha/lib/runnable.js:185:5)

at callFn (/home/travis/build/mozilla-b2g/gaia/node_modules/mocha/lib/runnable.js:228:7)

at Hook.Runnable.run (/home/travis/build/mozilla-b2g/gaia/node_modules/mocha/lib/runnable.js:216:7)

at next (/home/travis/build/mozilla-b2g/gaia/node_modules/mocha/lib/runner.js:259:10)

at /home/travis/build/mozilla-b2g/gaia/node_modules/mocha/lib/runner.js:271:7

at done (/home/travis/build/mozilla-b2g/gaia/node_modules/mocha/lib/runnable.js:185:5)

at /home/travis/build/mozilla-b2g/gaia/node_modules/mocha/lib/runnable.js:199:9

at Object.executeHook (/home/travis/build/mozilla-b2g/gaia/node_modules/marionette-client/lib/marionette/client.js:369:18)

at process._tickCallback (node.js:415:13)


Francisco, are you the right person to look at this?

Comment 1

[Francisco Jordano [:arcturus] [:francisco]]

A bit dissapointing to see how this integration test seems to be failing 21% of the cases:

https://travis-ci.org/arcturus/gaia/builds/26240131

Comment 2

[Kevin Grandon :kgrandon]

Based on the screenshot, the test is working, we should just update the final wait I think.

client.helper.waitForElement(selectors.editMenu) seems to not be working so well when the keyboard is up.

Comment 3

[Kevin Grandon :kgrandon]

Attachment: Github pull request

This is a potential patch. It seems like we should actually wait for the buttons to be hidden. We are currently doing the opposite assertion, which may fail because the buttons animate down.

Comment 4

[Kevin Grandon :kgrandon]

Comment on attachment 8430237 [details] [review]
Github pull request

I have a green on travis, and this logic makes sense to me. Francisco, what do you think?

Comment 5

[Francisco Jordano [:arcturus] [:francisco]]

Ok folks, 

I think I got it. Problem was related to the keyboard, and how te test was checking that one element was hidden or not.

We were checking the position of the element respect of the body, and that works when the keyboard is closed, but if the keyboard is open, or closing or opening, that changes.

If the machine is not overloaded and the keyboard has enough time to dissapear everything was working right, in cases of high load, we got the intermitents.

Got the test working, and used Kevin's trick to run it against my gaia repo 20 times, working fine all of them:

https://travis-ci.org/arcturus/gaia/builds/26285646

Now I'll do the proper PR (without the travis changes) to fix this issue.

Also I'm creating a small script to run against your own gaia repo to perform this repetitive test agains a single app or single test to check for intermitents.

Thanks folks!

Comment 6

[Francisco Jordano [:arcturus] [:francisco]]

(In reply to Kevin Grandon :kgrandon from comment #4)
> Comment on attachment 8430237 [details] [review]
> Github pull request
> 
> I have a green on travis, and this logic makes sense to me. Francisco, what
> do you think?

Great! Just posted my latest comment without seeing your work. I got to the same solution asking for the editMenu to be not visible, run it 20 times and not intermitent anymore.

So mergin!

Thanks Kevin!

Comment 7

[Francisco Jordano [:arcturus] [:francisco]]

Comment on attachment 8430237 [details] [review]
Github pull request

Thanks again!

Comment 8

[Francisco Jordano [:arcturus] [:francisco]]

Landed:

https://github.com/KevinGrandon/gaia/commit/8118e2a259da4bc53941ce77b611afd5f0cbc9df

Comment 9

[James Burke [:jrburke]]

This still seems to be a problem, the build for this fix on master merge seemed to fail with the same problem:

https://travis-ci.org/mozilla-b2g/gaia/jobs/26288901

and pull requests still show some failures with this error.

Comment 10

[Kevin Grandon :kgrandon]

Ah, I think the element is perhaps already gone by the time we call client.helper.waitForElement(). I think we should probably just remove that assertion, I'm not sure there's a lot of value in it.

Comment 11

[Francisco Jordano [:arcturus] [:francisco]]

Attachment: Pointer to PR 19830

Unfortunately we need to check that cause that's precisely the test that we added to check that the menu dissappears when you are in edit mode and click on search.

I've run this PR 10 times in travis hopefully this works

Thanks!

Comment 12

[Kevin Grandon :kgrandon]

Comment on attachment 8431649 [details] [review]
Pointer to PR 19830

Nice, I didn't realize we had that helper so it's good to know about!

Comment 13

[Kevin Grandon :kgrandon]

Landed: https://github.com/mozilla-b2g/gaia/commit/c2583e1d02bf0b2840f96adb66c5ea6517db1371