Closed Bug 1016909 Opened 12 years ago Closed 12 years ago

[Dialer] Should not link to input_areas BB

Categories

(Firefox OS Graveyard :: Gaia::Dialer, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::Dialer
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(feature-b2g:2.0, b2g-v2.0 fixed)

Status:
VERIFIED FIXED
Milestone:
2.0 S3 (6june)
Project Flags:
feature-b2g 2.0
Tracking Flags:
Tracking Status
b2g-v2.0 --- fixed

People

(Reporter: paco, Assigned: paco)

References

Details

Attachments

(3 files, 1 obsolete file)

black-numbers.png
21.91 KB, image/png
Details
dialpad-white-numbers.png
25.06 KB, image/png
Details
patch in github
46 bytes, text/x-github-pull-request
rik
: review+
Details | Review
Attached image black-numbers.png —
No description provided.
Assignee: nobody → pacorampas
Summary: [Dialer] On dialpad, the input number should be white not black → [Dialer] Should not link to input_areas BB
Due to new input areas styles, now Dialpad input has dark text instead of withe. As we are not using this BB anywhere in the app, is easier getting rid of it.
We need to fix this as it's breacking the already implemented in the Dialpad Visual Refresh (https://bug950760.bugzilla.mozilla.org/attachment.cgi?id=8415185), so nominating to 2.0
Blocks: dialer-visual-refres
blocking-b2g: --- → 2.0?
Target Milestone: --- → 2.0 S3 (6june)
triage: major issue to VR. 2.0+
blocking-b2g: 2.0? → 2.0+
Attached file patch in github (obsolete) —
Attachment #8430620 - Flags: review?(anthony)
Attached file patch in github —
Attachment #8430620 - Attachment is obsolete: true
Attachment #8430620 - Flags: review?(anthony)
Attachment #8430627 - Flags: review?(anthony)
I don't think this is a blocker. The text is still readable here, so this just VD cleanup at this point. Definitely worth fixing, however.
blocking-b2g: 2.0+ → 2.0?
Hi Jason, I understand your comment but this is part of the Visual Refresh that it's our main/unique goal in Comms team for 2.0, so things that are not implementing as they are specified in the VR specs are breaking the "feature" that we want to implement. Anyway, as there is still one week for the feature landing, setting feature-b2g:2.0 and I will talk with the comms team about how we handle these VR bugs and the nominations after June 9th.
blocking-b2g: 2.0? → ---
feature-b2g: --- → 2.0
We've entered the last week of Sprint 3 and this bug is unassigned and blocking the 2.0 Visual Refresh. Please let me know who is implementing this.
Flags: needinfo?(jcheng)
^ Sigh, never mind. Wrong bug again. SO MANY BUGS OPEN. ^
Flags: needinfo?(jcheng)
Attachment #8430627 - Flags: review?(anthony) → review+
Merged: 751b2a43a254d0ed109e0e519b25f7e503d7e3ea
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Tested and working Hamachi 2.0 Gecko-7a31c32 Gaia-1bd6e89
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: